Linux block layer
 help / color / mirror / Atom feed
From: Ming Lei <ming.lei@redhat.com>
To: Uday Shankar <ushankar@purestorage.com>
Cc: Jens Axboe <axboe@kernel.dk>, linux-block@vger.kernel.org
Subject: Re: [PATCH v2 1/4] ublk: check recovery flags for validity
Date: Wed, 25 Sep 2024 11:43:27 +0800	[thread overview]
Message-ID: <ZvOG37CBbqitwZ5H@fedora> (raw)
In-Reply-To: <20240917002155.2044225-2-ushankar@purestorage.com>

On Mon, Sep 16, 2024 at 06:21:52PM -0600, Uday Shankar wrote:
> Setting UBLK_F_USER_RECOVERY_REISSUE without also setting
> UBLK_F_USER_RECOVERY is currently silently equivalent to not setting any
> recovery flags at all, even though that's obviously not intended. Check
> for this case and fail add_dev (with a paranoid warning to aid debugging
> any program which might rely on the old behavior) with EINVAL if it is
> detected.
> 
> Signed-off-by: Uday Shankar <ushankar@purestorage.com>

Reviewed-by: Ming Lei <ming.lei@redhat.com>


Thanks,
Ming


  reply	other threads:[~2024-09-25  3:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-17  0:21 [PATCH v2 0/4] ublk: support device recovery without I/O queueing Uday Shankar
2024-09-17  0:21 ` [PATCH v2 1/4] ublk: check recovery flags for validity Uday Shankar
2024-09-25  3:43   ` Ming Lei [this message]
2024-09-17  0:21 ` [PATCH v2 2/4] ublk: refactor recovery configuration flag helpers Uday Shankar
2024-09-25  3:54   ` Ming Lei
2024-09-17  0:21 ` [PATCH v2 3/4] ublk: merge stop_work and quiesce_work Uday Shankar
2024-09-17  0:21 ` [PATCH v2 4/4] ublk: support device recovery without I/O queueing Uday Shankar
2024-09-25 10:58   ` Ming Lei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZvOG37CBbqitwZ5H@fedora \
    --to=ming.lei@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=linux-block@vger.kernel.org \
    --cc=ushankar@purestorage.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox