From: Ming Lei <ming.lei@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
YangYang <yang.yang@vivo.com>,
linux-block@vger.kernel.org, linux-scsi@vger.kernel.org,
"Martin K. Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH 1/2] block: also mark disk-owned queues as dying in __blk_mark_disk_dead
Date: Wed, 16 Oct 2024 20:49:07 +0800 [thread overview]
Message-ID: <Zw-2Q1WeTtgJO_NI@fedora> (raw)
In-Reply-To: <20241016123240.GB18219@lst.de>
On Wed, Oct 16, 2024 at 02:32:40PM +0200, Christoph Hellwig wrote:
> On Wed, Oct 16, 2024 at 07:09:48PM +0800, Ming Lei wrote:
> > Setting QUEUE_FLAG_DYING may fail passthrough request for
> > !GD_OWNS_QUEUE, I guess this may cause SCSI regression.
>
> Yes, as clearly documented in the commit log.
The change need Cc linux-scsi.
> As the disk is going away there is no real point in sending these
> commands, but we have no really good way to distinguish between the
> cases.
scsi request queue has very different lifetime with gendisk, not sure the
above comment is correct.
Thanks,
Ming
next prev parent reply other threads:[~2024-10-16 12:49 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-09 11:38 try to avoid del_gendisk vs passthrough from ->release deadlocks v2 Christoph Hellwig
2024-10-09 11:38 ` [PATCH 1/2] block: also mark disk-owned queues as dying in __blk_mark_disk_dead Christoph Hellwig
2024-10-09 12:31 ` Sergey Senozhatsky
2024-10-09 12:41 ` Christoph Hellwig
2024-10-09 12:43 ` Sergey Senozhatsky
2024-10-09 13:49 ` Jens Axboe
2024-10-16 4:14 ` YangYang
2024-10-16 11:09 ` Ming Lei
2024-10-16 12:32 ` Christoph Hellwig
2024-10-16 12:49 ` Ming Lei [this message]
2024-10-16 13:35 ` Ming Lei
2024-10-19 1:25 ` Sergey Senozhatsky
2024-10-19 12:32 ` Ming Lei
2024-10-19 12:37 ` Sergey Senozhatsky
2024-10-19 12:50 ` Ming Lei
2024-10-19 12:58 ` Sergey Senozhatsky
2024-10-19 13:09 ` Ming Lei
2024-10-19 13:50 ` Sergey Senozhatsky
2024-10-19 15:03 ` Ming Lei
2024-10-19 15:11 ` Sergey Senozhatsky
2024-10-19 15:40 ` Sergey Senozhatsky
2024-10-28 5:44 ` Sergey Senozhatsky
2024-10-09 11:38 ` [PATCH 2/2] block: mark the disk dead before taking open_mutx in del_gendisk Christoph Hellwig
2024-10-16 4:15 ` YangYang
2024-10-16 2:09 ` try to avoid del_gendisk vs passthrough from ->release deadlocks v2 Sergey Senozhatsky
-- strict thread matches above, loose matches on Subject: below --
2024-10-08 11:57 RFC: try to avoid del_gendisk vs passthrough from ->release deadlocks Christoph Hellwig
2024-10-08 11:57 ` [PATCH 1/2] block: also mark disk-owned queues as dying in __blk_mark_disk_dead Christoph Hellwig
2024-10-09 5:06 ` Sergey Senozhatsky
2024-10-09 7:34 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zw-2Q1WeTtgJO_NI@fedora \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=senozhatsky@chromium.org \
--cc=yang.yang@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).