From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D42D4210C0A for ; Fri, 11 Oct 2024 12:17:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728649045; cv=none; b=p3VJmwCvagyZv4esbh9n7FkhVd08TQrB98sxYTQ//TSzoEtki+KzEHvTbURZ1nH+V2WcpohS9nbchHCsrS8T+bZV0gNmnN29NHRKnjuBv5kLdaPIv+lbAVe8RtqwxKtWA9mzMiq81u4LN5jC94OMZ4z8m55jZcSJX6QiZg34LzY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728649045; c=relaxed/simple; bh=xUgb4R5FICKpCQdMDBd10yi6Lqwa1iDP8UCTVv+3HFo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WqhBBo3xRC07Javq5Q+JUwYG2VDnKAKrI6uTPr0i/UmEx8EvH5YEZQEx7Y6Y5NeAVlTIMzKWPBmg1E6nWOV/aHRQ+RSso538P42EDdHGUphFgmUBTAs5e0WqeBeRcV2iaE1BBoXGPEVaFlPM0fmvgayxF3dkiRiM+vWiwFL2D5Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=KHoSxefM; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="KHoSxefM" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728649043; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NfRk+zZ1X+PHF3tfT7ep00eGftErXB3cJqE2i/veZMM=; b=KHoSxefMESe+pq9i5ZDilt/HabH4b/enTVmQQqYJ0IFW5PKDrXQt5S06l9Cz1Jqt97Q5v0 DbDw4oevcAIRI4MRHlKP58Qs+abvH28fTefhq4wEWHIosyJUwZN20QGA8PJ2IIirxvaLmb hpOIL1Ojulon4YbWNj3qEEhwny7juKE= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-176-jEs7gmNTMMSDn8Vhnicqcg-1; Fri, 11 Oct 2024 08:17:17 -0400 X-MC-Unique: jEs7gmNTMMSDn8Vhnicqcg-1 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 410931954AE1; Fri, 11 Oct 2024 12:17:16 +0000 (UTC) Received: from fedora (unknown [10.72.116.16]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 662EA1956052; Fri, 11 Oct 2024 12:17:09 +0000 (UTC) Date: Fri, 11 Oct 2024 20:17:04 +0800 From: Ming Lei To: Christoph Hellwig Cc: Jens Axboe , Andrew Morton , Alexander Viro , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, David Howells Subject: Re: [PATCH V2] lib/iov_iter.c: extract virt-contiguous pages in iov_iter_extract_bvec_pages Message-ID: References: <20241011035247.2444033-1-ming.lei@redhat.com> Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 On Fri, Oct 11, 2024 at 05:08:37AM -0700, Christoph Hellwig wrote: > On Fri, Oct 11, 2024 at 08:03:49PM +0800, Ming Lei wrote: > > Looks open-code iterator is more readable, the patch looks fine, and > > I have verified it works as expected. > > Do you want me to resend this formally or pick it up from here? > (either way you should be credited as my take was just a trivial > cleanup) Yeah, please re-send the patch formally. Thanks, Ming