From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C03078825 for ; Wed, 23 Oct 2024 02:15:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729649761; cv=none; b=cY7qTo+OnxOgn8hvq4SpzSStc31DW8sGDx7isiOPMkrWEMJ5rGAeB95JHpE4Kc6A0vUFCQQbRPSGYTD+nazummOzLDG4AllG+hkxKVrVKWO1bjMorzxox2Do1HkQzX9IxW2vGTE+3ne/QNIaumFauRzMiz342FHa7s/5ftY+GPc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729649761; c=relaxed/simple; bh=Rxp/VQMU1PU9c1THWr5ynYdOTndthDFX+dUvvPPAWdI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kGUQ3DtAovlt+JudSFN6ps/Ibd41bWQcgVQlV4Zk3yD/r4iNzqzqPbVGVvQ4GEolpJifQzluqHKQUrQNwrncC7EFxc5KsyGYgmRPP19v3MlND238m18TO7khEb/alHm2XyexgEicd1uG3bjn24W8UqLIMA8WwJItQxVFZ62YWpI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=jSmzT7b1; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="jSmzT7b1" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729649758; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7L4MhxCYhofNtLg+tXJAr77AFE/k5Jqpq5D0/+wLQY0=; b=jSmzT7b1xSaFpPhFkV1sP840l6V2O+von4fsoszzfkE3MRIo0fhgdrswiSnS/EvfFHn3tN RBLP8lKXAmAYECs21og/2E5L0KjyQutO9aCCrf6rLSaIDALc5BLj3L7emvMm6yHOUdVuar nmvwRBZJmim0dNowHTwOwCdTmAttMG4= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-651-uwIhkWCqM1mc3HExexN2WA-1; Tue, 22 Oct 2024 22:15:55 -0400 X-MC-Unique: uwIhkWCqM1mc3HExexN2WA-1 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1192E19560AA; Wed, 23 Oct 2024 02:15:54 +0000 (UTC) Received: from fedora (unknown [10.72.116.47]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D8D7D1956056; Wed, 23 Oct 2024 02:15:48 +0000 (UTC) Date: Wed, 23 Oct 2024 10:15:43 +0800 From: Ming Lei To: Bart Van Assche Cc: Jens Axboe , linux-block@vger.kernel.org, Christoph Hellwig , Peter Wang , Chao Leng , stable@vger.kernel.org Subject: Re: [PATCH] blk-mq: Make blk_mq_quiesce_tagset() hold the tag list mutex less long Message-ID: References: <20241022181617.2716173-1-bvanassche@acm.org> Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241022181617.2716173-1-bvanassche@acm.org> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 On Tue, Oct 22, 2024 at 11:16:17AM -0700, Bart Van Assche wrote: > Make sure that the tag_list_lock mutex is no longer held than necessary. > This change reduces latency if e.g. blk_mq_quiesce_tagset() is called > concurrently from more than one thread. This function is used by the > NVMe core and also by the UFS driver. > > Reported-by: Peter Wang > Cc: Chao Leng > Cc: Ming Lei > Cc: stable@vger.kernel.org > Fixes: commit 414dd48e882c ("blk-mq: add tagset quiesce interface") > Signed-off-by: Bart Van Assche Reviewed-by: Ming Lei Thanks, Ming