From: Uday Shankar <ushankar@purestorage.com>
To: Ming Lei <ming.lei@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>,
io-uring@vger.kernel.org, Pavel Begunkov <asml.silence@gmail.com>,
linux-block@vger.kernel.org
Subject: Re: [PATCH V7 5/7] io_uring: support leased group buffer with REQ_F_GROUP_KBUF
Date: Thu, 24 Oct 2024 00:13:44 -0600 [thread overview]
Message-ID: <ZxnlmNGYWz+AikvV@dev-ushankar.dev.purestorage.com> (raw)
In-Reply-To: <20241012085330.2540955-6-ming.lei@redhat.com>
On Sat, Oct 12, 2024 at 04:53:25PM +0800, Ming Lei wrote:
> +int io_import_group_kbuf(struct io_kiocb *req, unsigned long buf_off,
> + unsigned int len, int dir, struct iov_iter *iter)
> +{
> + struct io_kiocb *lead = req->grp_link;
This works since grp_link and grp_leader are in a union together, but
this should really be req->grp_leader, right?
next prev parent reply other threads:[~2024-10-24 6:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-12 8:53 [PATCH V7 0/8] io_uring: support sqe group and leased group kbuf Ming Lei
2024-10-12 8:53 ` [PATCH V7 1/7] io_uring: add io_link_req() helper Ming Lei
2024-10-12 8:53 ` [PATCH V7 2/7] io_uring: add io_submit_fail_link() helper Ming Lei
2024-10-12 8:53 ` [PATCH V7 3/7] io_uring: add helper of io_req_commit_cqe() Ming Lei
2024-10-12 8:53 ` [PATCH V7 4/7] io_uring: support SQE group Ming Lei
2024-10-12 8:53 ` [PATCH V7 5/7] io_uring: support leased group buffer with REQ_F_GROUP_KBUF Ming Lei
2024-10-24 6:13 ` Uday Shankar [this message]
2024-10-24 6:32 ` Ming Lei
2024-10-12 8:53 ` [PATCH V7 6/7] io_uring/uring_cmd: support leasing device kernel buffer to io_uring Ming Lei
2024-10-12 8:53 ` [PATCH V7 7/7] ublk: support lease io " Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZxnlmNGYWz+AikvV@dev-ushankar.dev.purestorage.com \
--to=ushankar@purestorage.com \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).