public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
From: Ziyang Zhang <ZiyangZhang@linux.alibaba.com>
To: Ming Lei <ming.lei@redhat.com>
Cc: linux-block@vger.kernel.org,
	Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Subject: Re: [PATCH blktests v3 1/2] src: add mini ublk source code
Date: Fri, 24 Feb 2023 15:52:28 +0800	[thread overview]
Message-ID: <a20a449a-73c1-c7dd-b100-89e346c35828@linux.alibaba.com> (raw)
In-Reply-To: <20230220034649.1522978-2-ming.lei@redhat.com>

On 2023/2/20 11:46, Ming Lei wrote:

[...]

> 
> Signed-off-by: Ming Lei <ming.lei@redhat.com>
> ---
>  src/.gitignore |    1 +
>  src/Makefile   |   18 +
>  src/miniublk.c | 1376 ++++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 1395 insertions(+)
>  create mode 100644 src/miniublk.c
> 
> diff --git a/src/.gitignore b/src/.gitignore
> index 355bed3..df7aff5 100644
> --- a/src/.gitignore
> +++ b/src/.gitignore
> @@ -8,3 +8,4 @@
>  /sg/dxfer-from-dev
>  /sg/syzkaller1
>  /zbdioctl
> +/miniublk
> diff --git a/src/Makefile b/src/Makefile
> index 3b587f6..81c6541 100644
> --- a/src/Makefile
> +++ b/src/Makefile
> @@ -2,6 +2,10 @@ HAVE_C_HEADER = $(shell if echo "\#include <$(1)>" |		\
>  		$(CC) -E - > /dev/null 2>&1; then echo "$(2)";	\
>  		else echo "$(3)"; fi)
>  
> +HAVE_C_MACRO = $(shell if echo "#include <$(1)>" |	\
Hi Ming,

It should be "\#include", not "#include". You miss a "\".

Regards,
Zhang

  parent reply	other threads:[~2023-02-24  7:52 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-20  3:46 [PATCH blktests v3 0/2] blktests: add mini ublk source and blktests/033 Ming Lei
2023-02-20  3:46 ` [PATCH blktests v3 1/2] src: add mini ublk source code Ming Lei
2023-02-21 19:58   ` Chaitanya Kulkarni
2023-02-24  8:40     ` Ming Lei
2023-02-24  8:45       ` Ming Lei
2023-02-24  7:52   ` Ziyang Zhang [this message]
2023-02-24  8:28     ` Ming Lei
2023-02-24 11:41       ` Shinichiro Kawasaki
2023-02-27  2:57         ` Ziyang Zhang
2023-02-27  5:41           ` Shinichiro Kawasaki
2023-02-27  6:10             ` Ziyang Zhang
2023-02-28  9:25               ` Shinichiro Kawasaki
2023-02-20  3:46 ` [PATCH blktests v3 2/2] block/033: add test to cover gendisk leak Ming Lei
2023-02-20 13:03 ` [PATCH blktests v3 0/2] blktests: add mini ublk source and blktests/033 Shinichiro Kawasaki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a20a449a-73c1-c7dd-b100-89e346c35828@linux.alibaba.com \
    --to=ziyangzhang@linux.alibaba.com \
    --cc=linux-block@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    --cc=shinichiro.kawasaki@wdc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox