Re: [PATCH 1/5] sed-opal: do not add user authority twice in boolean ace.

Christoph Hellwig
2023-04-04T15:23:08Z

On Wed, Mar 29, 2023 at 05:20:29PM +0200, Ondrej Kozina wrote:
> It seemed redundant when only single authority is added in the set method
> aka { authority1, authority1, OR }:
>
> TCG Storage Architecture Core Specification, 5.1.3.3 ACE_expression
>
> "This is an alternative type where the options are either a uidref to an
> Authority object or one of the boolean_ACE (AND = 0 and OR = 1) options.
> This type is used within the AC_element list to form a postfix Boolean
> expression of Authorities."

Can you add this information to the commit message?

With that:

Reviewed-by: Christoph Hellwig <hch@lst.de>