From: Jens Axboe <axboe@kernel.dk>
To: Jan Kara <jack@suse.cz>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-block@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] block: Fixup condition detecting exclusive opener during partition rescan
Date: Thu, 1 Dec 2022 07:45:09 -0700 [thread overview]
Message-ID: <a3c9044e-d7ab-8130-76ea-a09152eacaea@kernel.dk> (raw)
In-Reply-To: <20221201114442.6829-1-jack@suse.cz>
On 12/1/22 4:44 AM, Jan Kara wrote:
> The condition detecting whether somebody else has the device exclusively
> open in disk_scan_partitions() has a brownpaper bag bug. It triggers also
> when nobody has the device exclusively open and we are coming from
> BLKRRPART path. Interestingly this didn't have any adverse effects
> during testing because tools update kernel's notion of the partition
> table using ioctls and don't rely on BLKRRPART. Fix the bug before
> somebody trips over it.
I folded this in. It's funny because I did consider this when reviewing
it, but then convinced myself it was fine...
--
Jens Axboe
prev parent reply other threads:[~2022-12-01 14:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 11:44 [PATCH] block: Fixup condition detecting exclusive opener during partition rescan Jan Kara
2022-12-01 14:45 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3c9044e-d7ab-8130-76ea-a09152eacaea@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox