* [PATCH] blk-mq: remove confusing comment of blk_mq_sched_dispatch_requests
@ 2018-01-05 7:09 Liu Bo
2018-01-05 15:36 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Liu Bo @ 2018-01-05 7:09 UTC (permalink / raw)
To: linux-block; +Cc: trivial
Commit de1482974080
("blk-mq: introduce .get_budget and .put_budget in blk_mq_ops")
changes the function to return bool type, and then commit 1f460b63d4b3
("blk-mq: don't restart queue when .get_budget returns BLK_STS_RESOURCE")
changes it back to void, but the comment remains.
Signed-off-by: Liu Bo <bo.li.liu@oracle.com>
---
block/blk-mq-sched.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/block/blk-mq-sched.c b/block/blk-mq-sched.c
index c117bd8..2ff7cf0 100644
--- a/block/blk-mq-sched.c
+++ b/block/blk-mq-sched.c
@@ -172,7 +172,6 @@ static void blk_mq_do_dispatch_ctx(struct blk_mq_hw_ctx *hctx)
WRITE_ONCE(hctx->dispatch_from, ctx);
}
-/* return true if hw queue need to be run again */
void blk_mq_sched_dispatch_requests(struct blk_mq_hw_ctx *hctx)
{
struct request_queue *q = hctx->queue;
--
2.9.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] blk-mq: remove confusing comment of blk_mq_sched_dispatch_requests
2018-01-05 7:09 [PATCH] blk-mq: remove confusing comment of blk_mq_sched_dispatch_requests Liu Bo
@ 2018-01-05 15:36 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2018-01-05 15:36 UTC (permalink / raw)
To: Liu Bo, linux-block; +Cc: trivial
On 1/5/18 12:09 AM, Liu Bo wrote:
> Commit de1482974080
> ("blk-mq: introduce .get_budget and .put_budget in blk_mq_ops")
> changes the function to return bool type, and then commit 1f460b63d4b3
> ("blk-mq: don't restart queue when .get_budget returns BLK_STS_RESOURCE")
> changes it back to void, but the comment remains.
Thanks, applied.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-05 15:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-05 7:09 [PATCH] blk-mq: remove confusing comment of blk_mq_sched_dispatch_requests Liu Bo
2018-01-05 15:36 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).