From: Jan Beulich <jbeulich@suse.com>
To: Juergen Gross <jgross@suse.com>
Cc: "Roger Pau Monné" <roger.pau@citrix.com>,
"Jens Axboe" <axboe@kernel.dk>,
xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
linux-block@vger.kernel.org
Subject: Re: [PATCH v2 4/4] xen/blkback: move blkif_get_x86_*_req() into blkback.c
Date: Tue, 14 Mar 2023 15:33:28 +0100 [thread overview]
Message-ID: <a4b422c6-eb08-89e5-9c97-4e0c4d0f8f01@suse.com> (raw)
In-Reply-To: <20230314142741.24917-5-jgross@suse.com>
On 14.03.2023 15:27, Juergen Gross wrote:
> V2:
> - add const, use unsigned int for loop counters (Roger Pau Monné)
Hmm, ...
> --- a/drivers/block/xen-blkback/blkback.c
> +++ b/drivers/block/xen-blkback/blkback.c
> @@ -1072,7 +1072,111 @@ static void end_block_io_op(struct bio *bio)
> bio_put(bio);
> }
>
> +static void blkif_get_x86_32_req(struct blkif_request *dst,
> + const struct blkif_x86_32_request *src)
> +{
> + unsigned int i, n;
... here you did, but ...
> +static void blkif_get_x86_64_req(struct blkif_request *dst,
> + struct blkif_x86_64_request *src)
> +{
> + int i, n;
... what about these?
Jan
next prev parent reply other threads:[~2023-03-14 14:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 14:27 [PATCH v2 0/4] xen/blkback: some cleanups Juergen Gross
2023-03-14 14:27 ` [PATCH v2 1/4] xen/blkback: fix white space code style issues Juergen Gross
2023-03-14 14:27 ` [PATCH v2 2/4] xen/blkback: remove stale prototype Juergen Gross
2023-03-14 14:27 ` [PATCH v2 3/4] xen/blkback: simplify free_persistent_gnts() interface Juergen Gross
2023-03-14 14:27 ` [PATCH v2 4/4] xen/blkback: move blkif_get_x86_*_req() into blkback.c Juergen Gross
2023-03-14 14:33 ` Jan Beulich [this message]
2023-03-14 14:41 ` Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4b422c6-eb08-89e5-9c97-4e0c4d0f8f01@suse.com \
--to=jbeulich@suse.com \
--cc=axboe@kernel.dk \
--cc=jgross@suse.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox