From: Jens Axboe <axboe@fb.com>
To: Omar Sandoval <osandov@osandov.com>, linux-block@vger.kernel.org
Cc: kernel-team@fb.com
Subject: Re: [PATCH] blk-mq-sched: (un)register elevator when (un)registering queue
Date: Mon, 6 Feb 2017 13:56:05 -0700 [thread overview]
Message-ID: <a500ef13-7a40-acc6-25ad-14726c74a07c@fb.com> (raw)
In-Reply-To: <ff62b5d76fa68f6595446d2a6c4aa13db4113d71.1486414181.git.osandov@fb.com>
On 02/06/2017 01:52 PM, Omar Sandoval wrote:
> From: Omar Sandoval <osandov@fb.com>
>
> I noticed that when booting with a default blk-mq I/O scheduler, the
> /sys/block/*/queue/iosched directory was missing. However, switching
> after boot did create the directory. This is because we skip the initial
> elevator register/unregister when we don't have a ->request_fn(), but we
> should still do it for the ->mq_ops case.
Good catch Omar, applied.
--
Jens Axboe
prev parent reply other threads:[~2017-02-06 20:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-06 20:52 [PATCH] blk-mq-sched: (un)register elevator when (un)registering queue Omar Sandoval
2017-02-06 20:56 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a500ef13-7a40-acc6-25ad-14726c74a07c@fb.com \
--to=axboe@fb.com \
--cc=kernel-team@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=osandov@osandov.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox