From: Hannes Reinecke <hare@suse.de>
To: Muneendra <muneendra.kumar@broadcom.com>,
linux-block@vger.kernel.org, linux-scsi@vger.kernel.org,
tj@kernel.org, linux-nvme@lists.infradead.org
Cc: jsmart2021@gmail.com, emilne@redhat.com, mkumar@redhat.com,
Gaurav Srivastava <gaurav.srivastava@broadcom.com>
Subject: Re: [PATCH v7 06/16] lpfc: vmid: Forward declarations for APIs
Date: Mon, 11 Jan 2021 08:35:13 +0100 [thread overview]
Message-ID: <a6dcbb12-8525-c88f-3ddc-2cdce2b1a166@suse.de> (raw)
In-Reply-To: <1609970430-19084-7-git-send-email-muneendra.kumar@broadcom.com>
On 1/6/21 11:00 PM, Muneendra wrote:
> From: Gaurav Srivastava <gaurav.srivastava@broadcom.com>
>
> This patch contains the forward declarations of commonly used APIs which
> are used outside the scope of the file.
>
> Signed-off-by: Gaurav Srivastava <gaurav.srivastava@broadcom.com>
> Signed-off-by: James Smart <jsmart2021@gmail.com>
>
> ---
> v7:
> No change
>
> v6:
> No change
>
> v5:
> No change
>
> v4:
> No change
>
> v3:
> No change
>
> v2:
> Ported the patch on top of 5.10/scsi-queue
> ---
> drivers/scsi/lpfc/lpfc_crtn.h | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/scsi/lpfc/lpfc_crtn.h b/drivers/scsi/lpfc/lpfc_crtn.h
> index f78e52a18b0b..7eb0200ecaa8 100644
> --- a/drivers/scsi/lpfc/lpfc_crtn.h
> +++ b/drivers/scsi/lpfc/lpfc_crtn.h
> @@ -606,3 +606,14 @@ extern unsigned long lpfc_no_hba_reset[];
> extern union lpfc_wqe128 lpfc_iread_cmd_template;
> extern union lpfc_wqe128 lpfc_iwrite_cmd_template;
> extern union lpfc_wqe128 lpfc_icmnd_cmd_template;
> +
> +/* vmid interface */
> +int lpfc_vmid_uvem(struct lpfc_vport *vport, struct lpfc_vmid *vmid, bool ins);
> +uint32_t lpfc_vmid_get_cs_ctl(struct lpfc_vport *vport);
> +int lpfc_vmid_cmd(struct lpfc_vport *vport,
> + int cmdcode, struct lpfc_vmid *vmid);
> +int lpfc_vmid_hash_fn(char *vmid, int len);
> +struct lpfc_vmid *lpfc_get_vmid_from_hastable(struct lpfc_vport *vport,
> + uint32_t hash, uint8_t *buf);
> +void lpfc_vmid_vport_cleanup(struct lpfc_vport *vport);
> +int lpfc_issue_els_qfpa(struct lpfc_vport *vport);
>
I'd rather merge this patch with that patch defining the functions; but
this is more a style issue.
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
next prev parent reply other threads:[~2021-01-11 7:35 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-06 22:00 [PATCH v7 00/16] blkcg:Support to track FC storage blk io traffic Muneendra
2021-01-06 22:00 ` [PATCH v7 01/16] cgroup: Added cgroup_get_from_id Muneendra
2021-01-11 7:29 ` Hannes Reinecke
2021-01-06 22:00 ` [PATCH v7 02/16] blkcg: Added a app identifier support for blkcg Muneendra
2021-01-11 7:30 ` Hannes Reinecke
2021-01-06 22:00 ` [PATCH v7 03/16] nvme: Added a newsysfs attribute appid_store Muneendra
2021-01-11 7:31 ` Hannes Reinecke
2021-01-06 22:00 ` [PATCH v7 04/16] lpfc: vmid: Add the datastructure for supporting VMID in lpfc Muneendra
2021-01-11 7:32 ` Hannes Reinecke
2021-01-06 22:00 ` [PATCH v7 05/16] lpfc: vmid: Supplementary data structures for vmid and APIs Muneendra
2021-01-11 7:33 ` Hannes Reinecke
2021-01-06 22:00 ` [PATCH v7 06/16] lpfc: vmid: Forward declarations for APIs Muneendra
2021-01-11 7:35 ` Hannes Reinecke [this message]
2021-01-06 22:00 ` [PATCH v7 07/16] lpfc: vmid: VMID params initialization Muneendra
2021-01-06 22:00 ` [PATCH v7 08/16] lpfc: vmid: Add support for vmid in mailbox command, does vmid resource allocation and vmid cleanup Muneendra
2021-01-06 22:00 ` [PATCH v7 09/16] lpfc: vmid: Implements ELS commands for appid patch Muneendra
2021-01-06 22:00 ` [PATCH v7 10/16] lpfc: vmid: Functions to manage vmids Muneendra
2021-01-06 22:00 ` [PATCH v7 11/16] lpfc: vmid: Implements CT commands for appid Muneendra
2021-01-06 22:00 ` [PATCH v7 12/16] lpfc: vmid: Appends the vmid in the wqe before sending Muneendra
2021-01-06 22:00 ` [PATCH v7 13/16] lpfc: vmid: Timeout implementation for vmid Muneendra
2021-01-06 22:00 ` [PATCH v7 14/16] lpfc: vmid: Adding qfpa and vmid timeout check in worker thread Muneendra
2021-01-06 22:00 ` [PATCH v7 15/16] lpfc: vmid: Introducing vmid in io path Muneendra
2021-01-06 22:00 ` [PATCH v7 16/16] scsi: Made changes in Kconfig to select BLK_CGROUP_FC_APPID Muneendra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6dcbb12-8525-c88f-3ddc-2cdce2b1a166@suse.de \
--to=hare@suse.de \
--cc=emilne@redhat.com \
--cc=gaurav.srivastava@broadcom.com \
--cc=jsmart2021@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mkumar@redhat.com \
--cc=muneendra.kumar@broadcom.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).