From: Hannes Reinecke <hare@suse.de>
To: Daniel Wagner <wagi@kernel.org>, Jens Axboe <axboe@kernel.dk>,
Keith Busch <kbusch@kernel.org>, Christoph Hellwig <hch@lst.de>,
Sagi Grimberg <sagi@grimberg.me>,
"Michael S. Tsirkin" <mst@redhat.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
Thomas Gleixner <tglx@linutronix.de>,
Costa Shulyupin <costa.shul@redhat.com>,
Juri Lelli <juri.lelli@redhat.com>,
Valentin Schneider <vschneid@redhat.com>,
Waiman Long <llong@redhat.com>, Ming Lei <ming.lei@redhat.com>,
Frederic Weisbecker <frederic@kernel.org>,
Mel Gorman <mgorman@suse.de>,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
linux-nvme@lists.infradead.org, megaraidlinux.pdl@broadcom.com,
linux-scsi@vger.kernel.org, storagedev@microchip.com,
virtualization@lists.linux.dev,
GR-QLogic-Storage-Upstream@marvell.com
Subject: Re: [PATCH v5 5/9] virtio: blk/scsi: use block layer helpers to calculate num of queues
Date: Mon, 13 Jan 2025 08:11:39 +0100 [thread overview]
Message-ID: <a7cd43e3-fac8-4917-8dc6-e2e8ba6cc797@suse.de> (raw)
In-Reply-To: <20250110-isolcpus-io-queues-v5-5-0e4f118680b0@kernel.org>
On 1/10/25 17:26, Daniel Wagner wrote:
> Multiqueue devices should only allocate queues for the housekeeping CPUs
> when isolcpus=managed_irq is set. This avoids that the isolated CPUs get
> disturbed with OS workload.
>
> Use helpers which calculates the correct number of queues which should
> be used when isolcpus is used.
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Acked-by: Michael S. Tsirkin <mst@redhat.com>
> Signed-off-by: Daniel Wagner <wagi@kernel.org>
> ---
> drivers/block/virtio_blk.c | 5 ++---
> drivers/scsi/virtio_scsi.c | 1 +
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich
next prev parent reply other threads:[~2025-01-13 7:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-10 16:26 [PATCH v5 0/9] blk: honor isolcpus configuration Daniel Wagner
2025-01-10 16:26 ` [PATCH v5 1/9] lib/group_cpus: let group_cpu_evenly return number initialized masks Daniel Wagner
2025-01-13 7:07 ` Hannes Reinecke
2025-01-10 16:26 ` [PATCH v5 2/9] blk-mq: add number of queue calc helper Daniel Wagner
2025-01-10 16:26 ` [PATCH v5 3/9] nvme-pci: use block layer helpers to calculate num of queues Daniel Wagner
2025-01-10 16:26 ` [PATCH v5 4/9] scsi: " Daniel Wagner
2025-01-10 21:37 ` Martin K. Petersen
2025-01-13 7:10 ` Hannes Reinecke
2025-01-10 16:26 ` [PATCH v5 5/9] virtio: blk/scsi: " Daniel Wagner
2025-01-13 7:11 ` Hannes Reinecke [this message]
2025-01-10 16:26 ` [PATCH v5 6/9] lib/group_cpus: honor housekeeping config when grouping CPUs Daniel Wagner
2025-01-10 16:26 ` [PATCH v5 7/9] blk-mq: use hk cpus only when isolcpus=managed_irq is enabled Daniel Wagner
2025-01-13 7:13 ` Hannes Reinecke
2025-01-10 16:26 ` [PATCH v5 8/9] blk-mq: issue warning when offlining hctx with online isolcpus Daniel Wagner
2025-01-11 3:40 ` Ming Lei
2025-01-13 7:14 ` Hannes Reinecke
2025-01-10 16:26 ` [PATCH v5 9/9] doc: update managed_irq documentation Daniel Wagner
2025-01-13 7:14 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7cd43e3-fac8-4917-8dc6-e2e8ba6cc797@suse.de \
--to=hare@suse.de \
--cc=GR-QLogic-Storage-Upstream@marvell.com \
--cc=axboe@kernel.dk \
--cc=costa.shul@redhat.com \
--cc=frederic@kernel.org \
--cc=hch@lst.de \
--cc=juri.lelli@redhat.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=llong@redhat.com \
--cc=martin.petersen@oracle.com \
--cc=megaraidlinux.pdl@broadcom.com \
--cc=mgorman@suse.de \
--cc=ming.lei@redhat.com \
--cc=mst@redhat.com \
--cc=sagi@grimberg.me \
--cc=storagedev@microchip.com \
--cc=tglx@linutronix.de \
--cc=virtualization@lists.linux.dev \
--cc=vschneid@redhat.com \
--cc=wagi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).