Re: [PATCH v3 8/9] blk-mq: Insert blk_pm_{add,put}_request() calls

Ming Lei
2018-08-03T00:11:43Z

On Fri, Aug 03, 2018 at 12:08:54AM +0000, Bart Van Assche wrote:
> On Fri, 2018-08-03 at 07:53 +0800, Ming Lei wrote:
> > blk_pm_add_request() calls pm_request_resume() for waking up device, but
> > it is wrong because it is async request, which can't guarantee device
> > will be ready before calling .queue_rq().
>
> That's a longstanding issue and not something that has been introduced by this
> patch series. Hence patch 6/9 that issues a warning if pm_request_resume() would
> be called.

It is introduced by your patch, please see blk_pm_allow_request().

Thanks,
Ming