From: Christoph Hellwig <hch@infradead.org>
To: Yu Kuai <yukuai1@huaweicloud.com>
Cc: axboe@kernel.dk, kbusch@kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, yukuai3@huawei.com,
yi.zhang@huawei.com, yangerkun@huawei.com,
johnny.chenyi@huawei.com
Subject: Re: [PATCH 4/5] brd: fix discard end sector
Date: Sun, 20 Apr 2025 22:26:38 -0700 [thread overview]
Message-ID: <aAXXDs1t_WUekH0y@infradead.org> (raw)
In-Reply-To: <20250418093826.3149293-5-yukuai1@huaweicloud.com>
On Fri, Apr 18, 2025 at 05:38:25PM +0800, Yu Kuai wrote:
> + sector_t aligned_end = round_down(sector + (size >> SECTOR_SHIFT),
> + PAGE_SECTORS);
Nit: I think the version below would be a bit more readable:
sector_t aligned_end =
round_down(sector + (size >> SECTOR_SHIFT), PAGE_SECTORS);
otherwise look good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2025-04-21 5:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-18 9:38 [PATCH 0/5] brd: discard bugfix Yu Kuai
2025-04-18 9:38 ` [PATCH 1/5] brd: fix oops if write concurrent with discard Yu Kuai
2025-04-21 5:22 ` Christoph Hellwig
2025-04-18 9:38 ` [PATCH 2/5] brd: synchronize using page and free page with rcu Yu Kuai
2025-04-21 5:24 ` Christoph Hellwig
2025-04-21 7:08 ` Yu Kuai
2025-04-18 9:38 ` [PATCH 3/5] brd: fix aligned_sector from brd_do_discard() Yu Kuai
2025-04-21 5:25 ` Christoph Hellwig
2025-04-18 9:38 ` [PATCH 4/5] brd: fix discard end sector Yu Kuai
2025-04-21 5:26 ` Christoph Hellwig [this message]
2025-04-18 9:38 ` [PATCH 5/5] brd: zero data for discard that is not aligned to page Yu Kuai
2025-04-21 5:27 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aAXXDs1t_WUekH0y@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=johnny.chenyi@huawei.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox