public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Zizhi Wo <wozizhi@huaweicloud.com>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org,
	yangerkun@huawei.com, yukuai3@huawei.com, ming.lei@redhat.com,
	tj@kernel.org
Subject: Re: [PATCH V3 4/7] blk-throttle: Introduce flag "BIO_TG_BPS_THROTTLED"
Date: Mon, 21 Apr 2025 05:03:36 -0700	[thread overview]
Message-ID: <aAY0GNzcJH28OEtA@infradead.org> (raw)
In-Reply-To: <20250418040924.486324-5-wozizhi@huaweicloud.com>

On Fri, Apr 18, 2025 at 12:09:21PM +0800, Zizhi Wo wrote:
> +	/*
> +	 * This bio has undergone rate limiting at the single throtl_grp level bps
> +	 * queue. Since throttle and QoS are not at the same level, reuse the value.
> +	 */

Please limit your comments to 80 characters to keep them readable.

But I also don't understand what "level" even means here.


  reply	other threads:[~2025-04-21 12:03 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-18  4:09 [PATCH V3 0/7] blk-throttle: Split the blkthrotl queue to solve the IO delay issue Zizhi Wo
2025-04-18  4:09 ` [PATCH V3 1/7] blk-throttle: Rename tg_may_dispatch() to tg_dispatch_time() Zizhi Wo
2025-04-18  4:09 ` [PATCH V3 2/7] blk-throttle: Refactor tg_dispatch_time by extracting tg_dispatch_bps/iops_time Zizhi Wo
2025-04-18  4:09 ` [PATCH V3 3/7] blk-throttle: Split throtl_charge_bio() into bps and iops functions Zizhi Wo
2025-04-18  4:09 ` [PATCH V3 4/7] blk-throttle: Introduce flag "BIO_TG_BPS_THROTTLED" Zizhi Wo
2025-04-21 12:03   ` Christoph Hellwig [this message]
2025-04-21 12:22     ` Zizhi Wo
2025-04-21 12:43       ` Christoph Hellwig
2025-04-21 12:53         ` Zizhi Wo
2025-04-22  5:03           ` Christoph Hellwig
2025-04-22  6:35             ` Zizhi Wo
2025-04-18  4:09 ` [PATCH V3 5/7] blk-throttle: Split the blkthrotl queue Zizhi Wo
2025-04-18  4:09 ` [PATCH V3 6/7] blk-throttle: Split the service queue Zizhi Wo
2025-04-18  8:35   ` Yu Kuai
2025-04-18  4:09 ` [PATCH V3 7/7] blk-throttle: Prevents the bps restricted io from entering the bps queue again Zizhi Wo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aAY0GNzcJH28OEtA@infradead.org \
    --to=hch@infradead.org \
    --cc=axboe@kernel.dk \
    --cc=linux-block@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    --cc=tj@kernel.org \
    --cc=wozizhi@huaweicloud.com \
    --cc=yangerkun@huawei.com \
    --cc=yukuai3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox