From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7DF6D946C for ; Fri, 9 May 2025 01:44:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746755045; cv=none; b=ndR50lQ04heGwZRvt7nKuUOPePqmPSHfiutb0V2484pKu0gksYeD2At3svnXl9QsvZ5scIhaCwRPHKDHKOB5YAYbvgOgmynL8CID9WVDANIFjjGx8F94c/v6ZOgAZi3B4YCXrEYTY/benMnYN1uRH/JSevXAXwxu/XOV4keDQJw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746755045; c=relaxed/simple; bh=njVig9ivo+i7YZm6pL5avQT7b85PeWJst1byYA9XM5s=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NLdAuWzyY/Ts7vDNy/E5GtVdfm07Pp3OnKGITMDYY8YlPyY/Z4aQor+vMPqKcXzG1sTPg9/nk4l3AwrrfGLszckmA2f8XibmNHOe8SRADtJ2rVW6dL0TvAozmClF7A9OB2Kwn7FEa+payuxEAeZja2x0/Y4igW1HJR+KyfJDQEg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=SYL+RuRE; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="SYL+RuRE" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1746755042; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=R1UZqb8T+DJxJnFpIsj/84dkc0Y9kPgWUwdXxP3YPOQ=; b=SYL+RuREbWbwjDmGe7aqTUzQkzXRdhJxdE3nouwPJg7vA2s7I2WJ6bGtk4B5bE0c6eqmGa czLIgCJ7ISEmK2zDIgg0v6bcbhQ7iEn8Kv42pLhfY2ljTZKtzL2AxZLuI7FYkCP57HtG0t jmgfYvk1la7bono3zp6AvdNQKD8DdVU= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-512-X1ua77XCO4K_Xsqy8wczjg-1; Thu, 08 May 2025 21:43:58 -0400 X-MC-Unique: X1ua77XCO4K_Xsqy8wczjg-1 X-Mimecast-MFC-AGG-ID: X1ua77XCO4K_Xsqy8wczjg_1746755035 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id BB4F81956094; Fri, 9 May 2025 01:43:54 +0000 (UTC) Received: from fedora (unknown [10.72.116.120]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B54BF30001A1; Fri, 9 May 2025 01:43:41 +0000 (UTC) Date: Fri, 9 May 2025 09:43:36 +0800 From: Ming Lei To: Daniel Wagner Cc: Jens Axboe , Keith Busch , Christoph Hellwig , Sagi Grimberg , "Michael S. Tsirkin" , "Martin K. Petersen" , Thomas Gleixner , Costa Shulyupin , Juri Lelli , Valentin Schneider , Waiman Long , Frederic Weisbecker , Mel Gorman , Hannes Reinecke , Mathieu Desnoyers , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, megaraidlinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, storagedev@microchip.com, virtualization@lists.linux.dev, GR-QLogic-Storage-Upstream@marvell.com Subject: Re: [PATCH v6 2/9] blk-mq: add number of queue calc helper Message-ID: References: <20250424-isolcpus-io-queues-v6-0-9a53a870ca1f@kernel.org> <20250424-isolcpus-io-queues-v6-2-9a53a870ca1f@kernel.org> Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250424-isolcpus-io-queues-v6-2-9a53a870ca1f@kernel.org> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 On Thu, Apr 24, 2025 at 08:19:41PM +0200, Daniel Wagner wrote: > Multiqueue devices should only allocate queues for the housekeeping CPUs > when isolcpus=io_queue is set. This avoids that the isolated CPUs get > disturbed with OS workload. io_queue isn't introduced yet, so the commit log needs to be updated. Otherwise, looks fine: Reviewed-by: Ming Lei Thanks, Ming