public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
From: Ming Lei <ming.lei@redhat.com>
To: Jared Holzman <jholzman@nvidia.com>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	Jens Axboe <axboe@kernel.dk>
Subject: Re: Port to 6.14-stable - ublk: fix race between io_uring_cmd_complete_in_task and ublk_cancel_cmd
Date: Tue, 6 May 2025 10:13:34 +0800	[thread overview]
Message-ID: <aBlwTtmeZErD4gnH@fedora> (raw)
In-Reply-To: <9a10100c-9d76-4522-9f6c-d0a6ad32ca81@nvidia.com>

On Mon, May 05, 2025 at 07:06:37PM +0300, Jared Holzman wrote:
> Hi Ming,
> 
> I'm attempting to back port the fix for this issue to the 6.14-stable branch.
> 
> Greg Kroah-Hartman has already applied d6aa0c178bf8 - "ublk: call ublk_dispatch_req() for handling UBLK_U_IO_NEED_GET_DATA",
> but was unable to apply f40139fde527 cleanly.
> 
> I created the patch below. It applies and compiles, but when I rerun the scenario I get several hung tasks waiting on the ub->mutex
> which is being held by the following task:

Hi Jared,

You need to pull in the following patchset too:

https://lore.kernel.org/linux-block/20250416035444.99569-1-ming.lei@redhat.com/

which avoids ub->mutex in error handling code path.

I just picked them in the following tree:

https://github.com/ming1/linux/commits/linux-6.14.y/

Please test and see if they work for you.


Thanks,
Ming


  reply	other threads:[~2025-05-06  2:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-05 16:06 Port to 6.14-stable - ublk: fix race between io_uring_cmd_complete_in_task and ublk_cancel_cmd Jared Holzman
2025-05-06  2:13 ` Ming Lei [this message]
2025-05-06 13:16   ` Jared Holzman
2025-05-06 13:40     ` Ming Lei
2025-05-06 13:57       ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aBlwTtmeZErD4gnH@fedora \
    --to=ming.lei@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=jholzman@nvidia.com \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox