* [PATCH] ublk: remove io argument from ublk_auto_buf_reg_fallback()
@ 2025-05-21 16:07 Caleb Sander Mateos
2025-05-22 2:40 ` Ming Lei
2025-05-22 11:01 ` Jens Axboe
0 siblings, 2 replies; 3+ messages in thread
From: Caleb Sander Mateos @ 2025-05-21 16:07 UTC (permalink / raw)
To: Ming Lei, Jens Axboe; +Cc: Caleb Sander Mateos, linux-block, linux-kernel
The argument has been unused since the function was added, so remove it.
Signed-off-by: Caleb Sander Mateos <csander@purestorage.com>
---
drivers/block/ublk_drv.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/block/ublk_drv.c b/drivers/block/ublk_drv.c
index 1800cb14677e..7dffddd3fc7a 100644
--- a/drivers/block/ublk_drv.c
+++ b/drivers/block/ublk_drv.c
@@ -1181,11 +1181,11 @@ static inline void __ublk_abort_rq(struct ublk_queue *ubq,
blk_mq_requeue_request(rq, false);
else
blk_mq_end_request(rq, BLK_STS_IOERR);
}
-static void ublk_auto_buf_reg_fallback(struct request *req, struct ublk_io *io)
+static void ublk_auto_buf_reg_fallback(struct request *req)
{
const struct ublk_queue *ubq = req->mq_hctx->driver_data;
struct ublksrv_io_desc *iod = ublk_get_iod(ubq, req->tag);
struct ublk_rq_data *data = blk_mq_rq_to_pdu(req);
@@ -1207,11 +1207,11 @@ static bool ublk_auto_buf_reg(struct request *req, struct ublk_io *io,
ret = io_buffer_register_bvec(io->cmd, req, ublk_io_release,
pdu->buf.index, issue_flags);
if (ret) {
if (pdu->buf.flags & UBLK_AUTO_BUF_REG_FALLBACK) {
- ublk_auto_buf_reg_fallback(req, io);
+ ublk_auto_buf_reg_fallback(req);
return true;
}
blk_mq_end_request(req, BLK_STS_IOERR);
return false;
}
--
2.45.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ublk: remove io argument from ublk_auto_buf_reg_fallback()
2025-05-21 16:07 [PATCH] ublk: remove io argument from ublk_auto_buf_reg_fallback() Caleb Sander Mateos
@ 2025-05-22 2:40 ` Ming Lei
2025-05-22 11:01 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Ming Lei @ 2025-05-22 2:40 UTC (permalink / raw)
To: Caleb Sander Mateos; +Cc: Jens Axboe, linux-block, linux-kernel
On Wed, May 21, 2025 at 10:07:19AM -0600, Caleb Sander Mateos wrote:
> The argument has been unused since the function was added, so remove it.
>
> Signed-off-by: Caleb Sander Mateos <csander@purestorage.com>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Thanks,
Ming
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ublk: remove io argument from ublk_auto_buf_reg_fallback()
2025-05-21 16:07 [PATCH] ublk: remove io argument from ublk_auto_buf_reg_fallback() Caleb Sander Mateos
2025-05-22 2:40 ` Ming Lei
@ 2025-05-22 11:01 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2025-05-22 11:01 UTC (permalink / raw)
To: Ming Lei, Caleb Sander Mateos; +Cc: linux-block, linux-kernel
On Wed, 21 May 2025 10:07:19 -0600, Caleb Sander Mateos wrote:
> The argument has been unused since the function was added, so remove it.
>
>
Applied, thanks!
[1/1] ublk: remove io argument from ublk_auto_buf_reg_fallback()
commit: 5234f2c3e3010f1b9c90b617e92c4b38e3240914
Best regards,
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-05-22 11:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-21 16:07 [PATCH] ublk: remove io argument from ublk_auto_buf_reg_fallback() Caleb Sander Mateos
2025-05-22 2:40 ` Ming Lei
2025-05-22 11:01 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox