[PATCH] ublk: remove io argument from ublk_auto_buf_reg_fallback()

[PATCH] ublk: remove io argument from ublk_auto_buf_reg_fallback()

[Caleb Sander Mateos]

The argument has been unused since the function was added, so remove it.

Signed-off-by: Caleb Sander Mateos <csander@purestorage.com>
---
 drivers/block/ublk_drv.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/block/ublk_drv.c b/drivers/block/ublk_drv.c
index 1800cb14677e..7dffddd3fc7a 100644
--- a/drivers/block/ublk_drv.c
+++ b/drivers/block/ublk_drv.c
@@ -1181,11 +1181,11 @@ static inline void __ublk_abort_rq(struct ublk_queue *ubq,
 		blk_mq_requeue_request(rq, false);
 	else
 		blk_mq_end_request(rq, BLK_STS_IOERR);
 }
 
-static void ublk_auto_buf_reg_fallback(struct request *req, struct ublk_io *io)
+static void ublk_auto_buf_reg_fallback(struct request *req)
 {
 	const struct ublk_queue *ubq = req->mq_hctx->driver_data;
 	struct ublksrv_io_desc *iod = ublk_get_iod(ubq, req->tag);
 	struct ublk_rq_data *data = blk_mq_rq_to_pdu(req);
 
@@ -1207,11 +1207,11 @@ static bool ublk_auto_buf_reg(struct request *req, struct ublk_io *io,
 
 	ret = io_buffer_register_bvec(io->cmd, req, ublk_io_release,
 				      pdu->buf.index, issue_flags);
 	if (ret) {
 		if (pdu->buf.flags & UBLK_AUTO_BUF_REG_FALLBACK) {
-			ublk_auto_buf_reg_fallback(req, io);
+			ublk_auto_buf_reg_fallback(req);
 			return true;
 		}
 		blk_mq_end_request(req, BLK_STS_IOERR);
 		return false;
 	}
-- 
2.45.2

Re: [PATCH] ublk: remove io argument from ublk_auto_buf_reg_fallback()

[Ming Lei]

On Wed, May 21, 2025 at 10:07:19AM -0600, Caleb Sander Mateos wrote:
> The argument has been unused since the function was added, so remove it.
> 
> Signed-off-by: Caleb Sander Mateos <csander@purestorage.com>

Reviewed-by: Ming Lei <ming.lei@redhat.com>

Thanks, 
Ming

Re: [PATCH] ublk: remove io argument from ublk_auto_buf_reg_fallback()

[Jens Axboe]

On Wed, 21 May 2025 10:07:19 -0600, Caleb Sander Mateos wrote:
> The argument has been unused since the function was added, so remove it.
> 
> 

Applied, thanks!

[1/1] ublk: remove io argument from ublk_auto_buf_reg_fallback()
      commit: 5234f2c3e3010f1b9c90b617e92c4b38e3240914

Best regards,
-- 
Jens Axboe