From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50BD327AC25 for ; Thu, 29 May 2025 09:45:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748511962; cv=none; b=lsr/j5kGyg51lVtZYoOC95yh+KeincPHhiuKMK/qfEV+/TDxR6X2w6jFWp65SeoOpz/c+umzUe805yW1bQS5i6I7Frwh77ozGg163dyoEN/PBrd9b776egbJrzJk7zuxi5WmPD25Rhi6dqDt2Hwl6UzNr5OF1LtqHVfYHjKz6cE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748511962; c=relaxed/simple; bh=C3dsgHLbVyzKSPMLEtimqxXQ5ZlGknrd6JAeTwzY2QU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lIlyPAWAuYYsPrpnELh7p/ot9RzNnB6tJZUBrRGygX10C4t49giQpYpWsRGhXtoaQ5Ra0FbTBevy4KQ3DgrXryN4W9pa55vq9lgVltXmESJq7lqRQvDMzUYgsT2GJtHzqsr1lLGtdM9D/W1k9fixx/+7xIJnXHDFK89axNcZCjk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=PkpYX5zQ; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="PkpYX5zQ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748511959; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=guKLXomrM/e1x57KkYEEeXlGW3IrC3Z8fk0Z4EY8ZCQ=; b=PkpYX5zQRWgwqJctISz1iXPB4OCMJxkLUwk74V25CV3GAFn/JH6xCA7i8mIT8cjc6g9IkO WCztu+/eZ0YLLlCZToPv1t7U6GyFh7N2UiUVXcKiu76SsNPobAlklAZWzrzyNLzUrKvd8+ rO8Vy1JKUXFqMEA5T4j8i+XmPM9mjzo= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-26-b8JzpSiUMxSDojDNVwJUXQ-1; Thu, 29 May 2025 05:45:55 -0400 X-MC-Unique: b8JzpSiUMxSDojDNVwJUXQ-1 X-Mimecast-MFC-AGG-ID: b8JzpSiUMxSDojDNVwJUXQ_1748511954 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id EDF741850FD0; Thu, 29 May 2025 09:45:41 +0000 (UTC) Received: from fedora (unknown [10.72.116.35]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 775B519560AE; Thu, 29 May 2025 09:45:35 +0000 (UTC) Date: Thu, 29 May 2025 17:45:30 +0800 From: Ming Lei To: Uday Shankar Cc: Jens Axboe , Caleb Sander Mateos , Andrew Morton , Shuah Khan , Jonathan Corbet , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v7 3/8] selftests: ublk: kublk: tie sqe allocation to io instead of queue Message-ID: References: <20250527-ublk_task_per_io-v7-0-cbdbaf283baa@purestorage.com> <20250527-ublk_task_per_io-v7-3-cbdbaf283baa@purestorage.com> Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250527-ublk_task_per_io-v7-3-cbdbaf283baa@purestorage.com> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 On Tue, May 27, 2025 at 05:01:26PM -0600, Uday Shankar wrote: > We currently have a helper ublk_queue_alloc_sqes which the ublk targets > use to allocate SQEs for their own operations. However, as we move > towards decoupled ublk_queues and ublk server threads, this helper does > not make sense anymore. SQEs are allocated from rings, and we will have > one ring per thread to avoid locking. Change the SQE allocation helper > to ublk_io_alloc_sqes. Currently this still allocates SQEs from the io's > queue's ring, but when we fully decouple threads and queues, it will > allocate from the io's thread's ring instead. > > Signed-off-by: Uday Shankar Reviewed-by: Ming Lei Thanks, Ming