public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
From: Ming Lei <ming.lei@redhat.com>
To: Yoav Cohen <yoav@nvidia.com>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	Jared Holzman <jholzman@nvidia.com>
Subject: Re: ublk: Adding Latency Measurement Support to UBLK
Date: Fri, 6 Jun 2025 18:06:01 +0800	[thread overview]
Message-ID: <aEK9iSmuAJrulQDs@fedora> (raw)
In-Reply-To: <DM4PR12MB632854130D3793D4DF7A892DA96FA@DM4PR12MB6328.namprd12.prod.outlook.com>

On Thu, Jun 05, 2025 at 12:52:49PM +0000, Yoav Cohen wrote:
> Dear Ming,
> 
> We would like to propose adding support to the ublk server for measuring latency at each stage of the I/O path. Currently, we are missing key information from the ublk driver—for example, the exact time a completion queue entry (CQE) was issued for an I/O operation, or when an I/O reached the ublk driver.
> 
> After reviewing the code, it seems this information is not currently accessible. One possible approach could be to extend the ublksrv_io_desc structure when a specific flag is passed during the creation of the ublk device (or by some other mechanism).
> 
> We are very interested in contributing this feature but would appreciate your thoughts and feedback before proceeding.

One idea is to add some trace points which can be attached reliably by
ebpf program, then you can run any analysis on the collected data from
ebpf program.

Please see the block layer's example:

trace_block_rq_issue()
trace_block_rq_complete()
...


Thanks,
Ming


      reply	other threads:[~2025-06-06 10:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-05 12:52 ublk: Adding Latency Measurement Support to UBLK Yoav Cohen
2025-06-06 10:06 ` Ming Lei [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aEK9iSmuAJrulQDs@fedora \
    --to=ming.lei@redhat.com \
    --cc=jholzman@nvidia.com \
    --cc=linux-block@vger.kernel.org \
    --cc=yoav@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox