Re: [PATCH 1/2] block: Make __submit_bio_noacct() preserve the bio submission order

[Keith Busch <kbusch@kernel.org>]

On Wed, Jun 11, 2025 at 10:02:34AM +0900, Damien Le Moal wrote:
> On 6/11/25 10:00 AM, Keith Busch wrote:
> > Ah, thanks for pointing that out! In that case, could we have dm
> > consider the bio "abnormal" when bio_has_crypt_ctx(bio) is true? That
> > way it does the split-to-limits for these, and dm appears to do that
> > action very early before its own split/clone actions on the resulting
> > bio.
> 
> That sounds reasonable to me.

Cool, that's just this atop the previous patch:

---
diff --git a/drivers/md/dm.c b/drivers/md/dm.c
index 5ab7574c0c76a..d8a43f37a9283 100644
--- a/drivers/md/dm.c
+++ b/drivers/md/dm.c
@@ -1632,7 +1632,7 @@ static bool is_abnormal_io(struct bio *bio)
        case REQ_OP_READ:
        case REQ_OP_WRITE:
        case REQ_OP_FLUSH:
-               return false;
+               return bio_has_crypt_ctx(bio);
        case REQ_OP_DISCARD:
        case REQ_OP_SECURE_ERASE:
        case REQ_OP_WRITE_ZEROES:
--