From: Christoph Hellwig <hch@infradead.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: Christoph Hellwig <hch@infradead.org>,
"Mohamed Abuelfotoh, Hazem" <abuehaze@amazon.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [PATCH] block: use plug request list tail for one-shot backmerge attempt
Date: Thu, 12 Jun 2025 05:23:00 -0700 [thread overview]
Message-ID: <aErGpBWAMPyT2un9@infradead.org> (raw)
In-Reply-To: <505e4900-b814-47cd-9572-c0172fa0d01e@kernel.dk>
On Thu, Jun 12, 2025 at 06:21:14AM -0600, Jens Axboe wrote:
> It's certainly going to make the cached handling more expensive, as the
> doubly linked behavior there is just pointless. Generally LIFO behavior
> there is preferable. I'd strongly suggest we use the doubly linked side
> for dispatch, and retain singly linked for cached + completion. If not
> I'm 100% sure we're going to be revisiting this again down the line, and
> redo those parts yet again.
Yeah. For cached requests and completions it might even make sense
to have a simple fixed size array FIFO buffer..
next prev parent reply other threads:[~2025-06-12 12:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-11 14:53 [PATCH] block: use plug request list tail for one-shot backmerge attempt Jens Axboe
2025-06-11 16:55 ` Mohamed Abuelfotoh, Hazem
2025-06-11 17:53 ` Jens Axboe
2025-06-12 5:22 ` Christoph Hellwig
2025-06-12 5:23 ` Christoph Hellwig
2025-06-12 11:49 ` Jens Axboe
2025-06-12 11:56 ` Christoph Hellwig
2025-06-12 12:21 ` Jens Axboe
2025-06-12 12:23 ` Christoph Hellwig [this message]
2025-06-12 12:28 ` Jens Axboe
2025-06-16 13:11 ` Christoph Hellwig
2025-06-16 16:01 ` Caleb Sander Mateos
2025-06-17 2:36 ` Ming Lei
2025-06-17 4:39 ` Christoph Hellwig
2025-06-18 6:04 ` Hannes Reinecke
2025-06-12 12:27 ` Mohamed Abuelfotoh, Hazem
2025-06-24 10:45 ` Mohamed Abuelfotoh, Hazem
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aErGpBWAMPyT2un9@infradead.org \
--to=hch@infradead.org \
--cc=abuehaze@amazon.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox