From: Christoph Hellwig <hch@infradead.org>
To: Yu Kuai <yukuai3@huawei.com>
Cc: axboe@kernel.dk, hare@suse.de, hch@infradead.org,
john.g.garry@oracle.com, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, yi.zhang@redhat.com,
calvin@wbinvd.org, david@fromorbit.com, yukuai1@huaweicloud.com,
yi.zhang@huawei.com, yangerkun@huawei.com,
johnny.chenyi@huawei.com
Subject: Re: [PATCH v2] block: fix false warning in bdev_count_inflight_rw()
Date: Thu, 26 Jun 2025 06:33:47 -0700 [thread overview]
Message-ID: <aF1MOxsOm2tcc0Ct@infradead.org> (raw)
In-Reply-To: <20250626115743.1641443-1-yukuai3@huawei.com>
On Thu, Jun 26, 2025 at 07:57:43PM +0800, Yu Kuai wrote:
> static void bdev_count_inflight_rw(struct block_device *part,
> unsigned int inflight[2], bool mq_driver)
Why not pass the inflight arguments as signed? (and split it for
reads and writes as you did below)
Anyway, I think this is good enough to get a fix queued up ASAP,
but we can probably clean it up incrementally:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2025-06-26 13:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-26 11:57 [PATCH v2] block: fix false warning in bdev_count_inflight_rw() Yu Kuai
2025-06-26 13:33 ` Christoph Hellwig [this message]
2025-06-26 13:35 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aF1MOxsOm2tcc0Ct@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=calvin@wbinvd.org \
--cc=david@fromorbit.com \
--cc=hare@suse.de \
--cc=john.g.garry@oracle.com \
--cc=johnny.chenyi@huawei.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yi.zhang@redhat.com \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox