From: Frederic Weisbecker <frederic@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Jens Axboe <axboe@kernel.dk>,
Marco Crivellari <marco.crivellari@suse.com>,
Michal Hocko <mhocko@suse.com>,
Peter Zijlstra <peterz@infradead.org>, Tejun Heo <tj@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Vlastimil Babka <vbabka@suse.cz>,
Waiman Long <longman@redhat.com>,
linux-block@vger.kernel.org
Subject: Re: [PATCH 11/27] block: Protect against concurrent isolated cpuset change
Date: Thu, 26 Jun 2025 17:33:49 +0200 [thread overview]
Message-ID: <aF1oXYifR_jF7YSJ@localhost.localdomain> (raw)
In-Reply-To: <aFjqUXIyi9CuY0aM@infradead.org>
Le Sun, Jun 22, 2025 at 10:46:57PM -0700, Christoph Hellwig a écrit :
> On Fri, Jun 20, 2025 at 05:22:52PM +0200, Frederic Weisbecker wrote:
> > + * running block kworker on isolated CPUs.
> > + * FIXME: cpuset should propagate further changes to isolated CPUs
> > + * here.
>
> I have no idea what this comments means. Can you explain it, or help
> fixing it? Or at least send the entire series to all affected
> subsystems as there's no way to review it without the context.
>
> If nothing changes please at leat avoid the overly long line.
That's definetly confusing.
I'll try to clarify that on the next iteration, or even try to fix
it myself.
Thanks.
--
Frederic Weisbecker
SUSE Labs
prev parent reply other threads:[~2025-06-26 15:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250620152308.27492-1-frederic@kernel.org>
2025-06-20 15:22 ` [PATCH 11/27] block: Protect against concurrent isolated cpuset change Frederic Weisbecker
2025-06-20 15:59 ` Bart Van Assche
2025-06-26 15:03 ` Frederic Weisbecker
2025-06-23 5:46 ` Christoph Hellwig
2025-06-26 15:33 ` Frederic Weisbecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aF1oXYifR_jF7YSJ@localhost.localdomain \
--to=frederic@kernel.org \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=marco.crivellari@suse.com \
--cc=mhocko@suse.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox