Re: [PATCH 03/12] iomap: refactor the writeback interface

Christoph Hellwig
2025-06-30T05:42:37Z

On Fri, Jun 27, 2025 at 11:14:05AM -0400, Brian Foster wrote:
> > struct iomap_writeback_ops {
> > - int (*map_blocks)(struct iomap_writeback_ctx *wpc, struct inode *inode,
> > - loff_t offset, unsigned len);
> > - int (*submit_ioend)(struct iomap_writeback_ctx *wpc, int status);
> > - void (*discard_folio)(struct folio *folio, loff_t pos);
> > + int (*writeback_range)(struct iomap_writeback_ctx *wpc,
> > + struct folio *folio, u64 pos, unsigned int len, u64 end_pos);
>
> Whitespace damage on the above line.

Without this the vim syntax highlighting is confused for the rest of the
file unfortunately. Not sure how to deal with it, the RST formatting
keeps driving me crazy. As does this document, which really should
not duplicate the type information, but folks really wanted this
annoyingly redundant information that is a huge pain to maintain for no
gain at all :(