From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Thomas Fourier <fourier.thomas@gmail.com>
Cc: Jens Axboe <axboe@kernel.dk>, Philipp Stanner <phasta@kernel.org>,
Anuj Gupta <anuj20.g@samsung.com>,
Al Viro <viro@zeniv.linux.org.uk>, Li Zetao <lizetao1@huawei.com>,
Asai Thambi S P <asamymuthupa@micron.com>,
Sam Bradshaw <sbradshaw@micron.com>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block: mtip32xx: Fix usage of dma_map_sg()
Date: Fri, 27 Jun 2025 17:08:33 +0300 [thread overview]
Message-ID: <aF6l4STJBU7nXYS1@smile.fi.intel.com> (raw)
In-Reply-To: <20250627121123.203731-2-fourier.thomas@gmail.com>
On Fri, Jun 27, 2025 at 02:11:19PM +0200, Thomas Fourier wrote:
> The dma_map_sg() can fail and, in case of failure, returns 0. If it
> fails, mtip_hw_submit_io() returns an error.
>
> The dma_unmap_sg() requires the nents parameter to be the same as the
> one passed to dma_map_sg(). This patch saves the nents in
> command->scatter_ents.
I don't know why I'm in Cc list here, but FWIW,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
with a caveat that I am not an expert at all in these areas. Code
just look okay and doing sane things.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-06-27 14:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-27 12:11 [PATCH] block: mtip32xx: Fix usage of dma_map_sg() Thomas Fourier
2025-06-27 14:08 ` Andy Shevchenko [this message]
2025-07-08 18:00 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aF6l4STJBU7nXYS1@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=anuj20.g@samsung.com \
--cc=asamymuthupa@micron.com \
--cc=axboe@kernel.dk \
--cc=fourier.thomas@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizetao1@huawei.com \
--cc=phasta@kernel.org \
--cc=sbradshaw@micron.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox