From: Christoph Hellwig <hch@infradead.org>
To: Ming Lei <ming.lei@redhat.com>
Cc: Caleb Sander Mateos <csander@purestorage.com>,
Christoph Hellwig <hch@infradead.org>,
Jens Axboe <axboe@kernel.dk>,
"Mohamed Abuelfotoh, Hazem" <abuehaze@amazon.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [PATCH] block: use plug request list tail for one-shot backmerge attempt
Date: Mon, 16 Jun 2025 21:39:59 -0700 [thread overview]
Message-ID: <aFDxnwsLz8Mri3xr@infradead.org> (raw)
In-Reply-To: <aFDUlnKVHLJC6VuE@fedora>
On Tue, Jun 17, 2025 at 10:36:06AM +0800, Ming Lei wrote:
[full quote deleted, please fix your mailer]
> > ublk_cmd_list_tw_cb() doesn't need a doubly-linked list. It should be
> > fine to continue storing just the first struct request * of the list
> > in struct ublk_uring_cmd_pdu. That would avoid growing
> > ublk_uring_cmd_pdu past the 32-byte limit.
>
> Agree.
>
> ublk needn't re-order, and doubly-linked list is useless here.
No driver needs to reorder, it just needs to consume the list passed to
it, for which using list_cut_before is really useful. Just passing it
on would be optimal, but if that can't work the frankenlist proposed by
Caleb might work.
next prev parent reply other threads:[~2025-06-17 4:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-11 14:53 [PATCH] block: use plug request list tail for one-shot backmerge attempt Jens Axboe
2025-06-11 16:55 ` Mohamed Abuelfotoh, Hazem
2025-06-11 17:53 ` Jens Axboe
2025-06-12 5:22 ` Christoph Hellwig
2025-06-12 5:23 ` Christoph Hellwig
2025-06-12 11:49 ` Jens Axboe
2025-06-12 11:56 ` Christoph Hellwig
2025-06-12 12:21 ` Jens Axboe
2025-06-12 12:23 ` Christoph Hellwig
2025-06-12 12:28 ` Jens Axboe
2025-06-16 13:11 ` Christoph Hellwig
2025-06-16 16:01 ` Caleb Sander Mateos
2025-06-17 2:36 ` Ming Lei
2025-06-17 4:39 ` Christoph Hellwig [this message]
2025-06-18 6:04 ` Hannes Reinecke
2025-06-12 12:27 ` Mohamed Abuelfotoh, Hazem
2025-06-24 10:45 ` Mohamed Abuelfotoh, Hazem
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aFDxnwsLz8Mri3xr@infradead.org \
--to=hch@infradead.org \
--cc=abuehaze@amazon.com \
--cc=axboe@kernel.dk \
--cc=csander@purestorage.com \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox