Linux block layer
 help / color / mirror / Atom feed
From: Keith Busch <kbusch@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Hannes Reinecke <hare@suse.de>,
	Alan Adamson <alan.adamson@oracle.com>,
	John Garry <john.g.garry@oracle.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Jens Axboe <axboe@kernel.dk>,
	linux-nvme@lists.infradead.org, linux-block@vger.kernel.org
Subject: Re: What should we do about the nvme atomics mess?
Date: Tue, 8 Jul 2025 09:19:32 -0600	[thread overview]
Message-ID: <aG03BKRk7O5JfVtN@kbusch-mbp> (raw)
In-Reply-To: <20250708094748.GB27634@lst.de>

On Tue, Jul 08, 2025 at 11:47:48AM +0200, Christoph Hellwig wrote:
> On Mon, Jul 07, 2025 at 09:56:53AM -0600, Keith Busch wrote:
> > Just to throw AWUPF a lifeline for legecy devices, we could potentially
> > make sense of the value if Identify Controller says:
> > 
> >   1. CMIC == 0; and
> >   2. OACS.NMS == 0; and
> 
> What is NMS meant to say?  namespace management support?

Right, namespace management support. The spec calls this field 'NMS' now.
 
> >   3.
> >     a. FNA.FNS == 1; or
> >     b. NN == 1
> > 
> > And if those conditions are true, then the controller and namespace
> > scopes resolve to a single namespace format, so the values should be one
> > in the same. The only way it could change, then, is a format command,
> > which means there couldn't be an in-use filesystem depending on it not
> > changing.
> 
> We could.  But are there many controllers where that would be the
> case and where people want to use atomics?

Maybe not. I still have a lot of 1.0 compliant devices where this might
apply, but I don't have a use case explicitly needing the atomic write
features anyway, so it doesn't matter to me if the driver doesn't report
the limits for them.

So I guess no need to work with such devices at this point, but maybe
just something to consider in the unlikely event someone complains.

  reply	other threads:[~2025-07-08 15:19 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-07 14:18 What should we do about the nvme atomics mess? Christoph Hellwig
2025-07-07 14:24 ` Keith Busch
2025-07-07 15:26   ` Hannes Reinecke
2025-07-07 15:56     ` Keith Busch
2025-07-07 23:35       ` Chaitanya Kulkarni
2025-07-08  9:47       ` Christoph Hellwig
2025-07-08 15:19         ` Keith Busch [this message]
2025-07-08  1:27 ` Ming Lei
2025-07-08  2:27   ` Keith Busch
2025-07-08  2:46     ` Ming Lei
2025-07-08  2:56       ` Keith Busch
2025-07-08  3:17         ` Ming Lei
2025-07-08  9:38 ` Niklas Cassel
2025-07-08  9:48   ` Christoph Hellwig
2025-07-08 10:08 ` John Garry
2025-07-09  7:51 ` Nilay Shroff
2025-07-09 21:28   ` Keith Busch
2025-07-10  5:07     ` Nilay Shroff
2025-07-10  7:17       ` Christoph Hellwig
2025-10-20 13:42       ` John Garry
2025-10-21 15:02         ` Nilay Shroff
2025-10-22  8:50           ` John Garry
2025-10-22 15:24             ` Nilay Shroff
2025-12-08 12:11               ` Nilay Shroff
2025-12-09  8:26                 ` John Garry
2026-01-22 10:06                   ` Nilay Shroff
2026-01-22 10:16                     ` John Garry
2026-01-26 12:56                       ` Christoph Hellwig
2026-01-26 12:58                         ` John Garry
2026-01-26 13:01                         ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aG03BKRk7O5JfVtN@kbusch-mbp \
    --to=kbusch@kernel.org \
    --cc=alan.adamson@oracle.com \
    --cc=axboe@kernel.dk \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=john.g.garry@oracle.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox