From: Keith Busch <kbusch@kernel.org>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Nilay Shroff <nilay@linux.ibm.com>,
stable@vger.kernel.org
Subject: Re: [PATCH v2] block: Fix a deadlock related to modifying the readahead attribute
Date: Mon, 30 Jun 2025 18:42:49 -0600 [thread overview]
Message-ID: <aGMvCXklxJ_rlZOM@kbusch-mbp> (raw)
In-Reply-To: <d03ccb5c-f44c-40e7-9964-2e9ec67bb96f@acm.org>
On Mon, Jun 30, 2025 at 03:39:18PM -0700, Bart Van Assche wrote:
> On 6/27/25 12:17 AM, Christoph Hellwig wrote:
> > Well, if there are queued never completed bios the freeze will obviously
> > fail. I don't see how this freeze is special vs other freezes or other
> > attributes that freeze.
>
> Hi Christoph,
>
> Do you perhaps want me to remove the freeze/unfreeze calls from all
> sysfs store callbacks from which it is safe to remove these callbacks?
But don't the remaining attributes that are not safe remain susceptible
to this deadlock?
next prev parent reply other threads:[~2025-07-01 0:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-26 20:37 [PATCH v2] block: Fix a deadlock related to modifying the readahead attribute Bart Van Assche
2025-06-27 7:17 ` Christoph Hellwig
2025-06-28 22:58 ` Bart Van Assche
2025-06-30 22:39 ` Bart Van Assche
2025-07-01 0:42 ` Keith Busch [this message]
2025-07-01 1:50 ` Bart Van Assche
2025-07-01 5:08 ` Nilay Shroff
2025-07-01 5:12 ` Nilay Shroff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aGMvCXklxJ_rlZOM@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=nilay@linux.ibm.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox