From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f74.google.com (mail-ed1-f74.google.com [209.85.208.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD51326F471 for ; Tue, 1 Jul 2025 10:44:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751366655; cv=none; b=H9YP8Lp/QwpTw4izqbtKOQBFSmHOwFf/98PpnitBzHMLpdm57dXwFA/m/2fvlKEZwNHHTcmgDSnRdYIahOnRxn3nYq6TQQFB7RpDz94IAtCi+61eQhX6xMQqfWCzl9NJE7BvZVJih+1NbCRLPkTS8SHS+lOXQa691rXW+Kgen0s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751366655; c=relaxed/simple; bh=FjNNJQuNFHz/e6yt6+QF01AIHDz6pY4OvsUX2LurgSk=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=hLvlMJZW263sCPYgCtVJVUoR1sugUqc+sfxVJBUDgL1yH30VwjnUtgnySH/y5IYcn8IDwZytt10ZgJRxzFh3EIzZSJ+VOcyjc4ikwUfTWws/ZA7DJGLiS7P0sC6XihwCK12IQtryEZKgyCE1F7uFkrauBi4zQWqoPx7jZjISGsA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=yAXGl2UE; arc=none smtp.client-ip=209.85.208.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="yAXGl2UE" Received: by mail-ed1-f74.google.com with SMTP id 4fb4d7f45d1cf-607c239c7f0so2926889a12.3 for ; Tue, 01 Jul 2025 03:44:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1751366652; x=1751971452; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=KkP3Q/mrHcTXpi5jFAQSRZZTttwkOM8RfBay5zssxDs=; b=yAXGl2UE0qGFLEXo8I/Q2Me+hvVbD7mps4Qv0pBulP64GzRp969FW+u0lywERoqpQ1 ZjN7Z+eLDoqa7yoDrhFaRojz57rhL6Rir/zpwzCWKuPEEyGre87w/lCKpfuIR13kFpKf yCy6wzZ6QgkBK/ptREQ02Xm5pvimoCLIT3982qRqrBRkaoOSTgjddPD2/M0krisx/I70 x0/3GmhDt3zFn+6ov2RP3FHOBkSbhkVi2tlA2nKgBkQh2lw7FMQ85VQvaFylCsDlB98p buq6+GFlh7eDHsEvqV3s+Q8LCNNNGNncnj2SKXdG6kY62ZswTAKQnbbWL2vwc+JqJ/ZV lw0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751366652; x=1751971452; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KkP3Q/mrHcTXpi5jFAQSRZZTttwkOM8RfBay5zssxDs=; b=tTIiBn0S57GtscNZfc15Cqw3dSRwpvTCsnv8hiKNalLI5DoWheVq8Bzz5mP3rbodCg UiLESUyMVP3/+UIsHHmR8l3X6CUiFr6u4plxKdkrFXa1ee8+OFneH2j+qocRml3x5alm gIx8ULp+E5wTd8nVCquAJmizrlfhHyuKh6+FAX9F4lZVRYeqxVeyNLrnz5ex8Yb1s4GH qMDq83KMAaI+mQDAlDF2iw1qgranldAISQA//BLM/C3zNRgKninENz42A1Zhdcf/Kt8p e/UXk2KBgF/I92gODVdhlQrPJ/wVJOQ28Cl7vvdaawAigRHAZd8SB1p/+EaI2T7OS2MD 6YSA== X-Forwarded-Encrypted: i=1; AJvYcCV3Fb9trBYM0BOecXSKNbb2ibLkrG96k+e4flDXSklgyHq8CXBzVleuSPM3pWHTDMcBc+pwgNDtE9Jxyw==@vger.kernel.org X-Gm-Message-State: AOJu0Yy4dJzrpQmAwjEgtyC8aTxV+FojMX72FupjWQXv5xeUHdTbvZNf F4Lv8wQH9SmVNIDveKa+FjE+sz+iMDIp9hu8hDFio/kagRBeMElTV9TfNyHO6R1vij58yQfdDfx uErlOmJWdFyH798TvIA== X-Google-Smtp-Source: AGHT+IFVVYwcwXIW2+rs+LXCKTLno19A5yuxBI/UefmvL0JcGML1UYLUePmSmcmNLPYFZsBsDSZ4dtmzcyM66Ug= X-Received: from edwf17.prod.google.com ([2002:a05:6402:1511:b0:60c:3b8e:c3eb]) (user=aliceryhl job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6402:26d4:b0:607:f431:33fb with SMTP id 4fb4d7f45d1cf-60c88b26b30mr16470283a12.3.1751366650570; Tue, 01 Jul 2025 03:44:10 -0700 (PDT) Date: Tue, 1 Jul 2025 10:44:09 +0000 In-Reply-To: <20250619-cstr-core-v12-0-80c9c7b45900@gmail.com> Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250619-cstr-core-v12-0-80c9c7b45900@gmail.com> Message-ID: Subject: Re: [PATCH v12 0/5] rust: replace kernel::str::CStr w/ core::ffi::CStr From: Alice Ryhl To: Tamir Duberstein Cc: Michal Rostecki , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , "=?utf-8?B?QmrDtnJu?= Roy Baron" , Andreas Hindborg , Trevor Gross , Brendan Higgins , David Gow , Rae Moar , Danilo Krummrich , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Greg Kroah-Hartman , "Rafael J. Wysocki" , Luis Chamberlain , Russ Weight , FUJITA Tomonori , Rob Herring , Saravana Kannan , Peter Zijlstra , Ingo Molnar , Will Deacon , Waiman Long , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Bjorn Helgaas , Arnd Bergmann , Jens Axboe , Benno Lossin , "Krzysztof =?utf-8?Q?Wilczy=C5=84ski?=" , Dave Ertman , Ira Weiny , Leon Romanovsky , Breno Leitao , Viresh Kumar , Michael Turquette , Stephen Boyd , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, dri-devel@lists.freedesktop.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, llvm@lists.linux.dev, linux-pci@vger.kernel.org, nouveau@lists.freedesktop.org, linux-block@vger.kernel.org, linux-pm@vger.kernel.org, linux-clk@vger.kernel.org Content-Type: text/plain; charset="utf-8" On Thu, Jun 19, 2025 at 11:06:24AM -0400, Tamir Duberstein wrote: > This picks up from Michal Rostecki's work[0]. Per Michal's guidance I > have omitted Co-authored tags, as the end result is quite different. > > Link: https://lore.kernel.org/rust-for-linux/20240819153656.28807-2-vadorovsky@protonmail.com/t/#u [0] > Closes: https://github.com/Rust-for-Linux/linux/issues/1075 > > Signed-off-by: Tamir Duberstein Overall LGTM. Only question is whether we should re-export core::ffi::CStr from kernel::ffi. Reason being that right now we are telling people to never use core::ffi as the integer types are wrong, and I think it would be nice if we can continue to tell people "never use core::ffi". Either way, for the whole series: Reviewed-by: Alice Ryhl Alice