From: Matthew Wilcox <willy@infradead.org>
To: "hch@infradead.org" <hch@infradead.org>
Cc: "陈涛涛 Taotao Chen" <chentaotao@didiglobal.com>,
"tytso@mit.edu" <tytso@mit.edu>,
"adilger.kernel@dilger.ca" <adilger.kernel@dilger.ca>,
"brauner@kernel.org" <brauner@kernel.org>,
"jani.nikula@linux.intel.com" <jani.nikula@linux.intel.com>,
"rodrigo.vivi@intel.com" <rodrigo.vivi@intel.com>,
"tursulin@ursulin.net" <tursulin@ursulin.net>,
"airlied@gmail.com" <airlied@gmail.com>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"chentao325@qq.com" <chentao325@qq.com>,
"frank.li@vivo.com" <frank.li@vivo.com>
Subject: Re: [PATCH v3 4/4] ext4: support uncached buffered I/O
Date: Thu, 3 Jul 2025 12:45:53 +0100 [thread overview]
Message-ID: <aGZtcSIryAj4zJtF@casper.infradead.org> (raw)
In-Reply-To: <aGIxiOeJ_-lmRmiT@infradead.org>
On Sun, Jun 29, 2025 at 11:41:12PM -0700, hch@infradead.org wrote:
> On Fri, Jun 27, 2025 at 06:03:09PM +0100, Matthew Wilcox wrote:
> > On Fri, Jun 27, 2025 at 11:03:13AM +0000, 陈涛涛 Taotao Chen wrote:
> > I think this needs to be:
> >
> > if (iocb && iocb->ki_flags & IOCB_DONTCACHE)
> >
> > because it's legit to call write_begin with a NULL argument. The
> > 'file' was always an optional argument, and we should preserve that
> > optionality with this transformation.
>
> write_begin and write_end are only callbacks through helpers called
> by the file system. So if the file system never passes a NULL
> file/kiocb it doesn't need to check for it.
Sure, but some of those helpers are non-obvious, like page_symlink().
prev parent reply other threads:[~2025-07-03 11:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-27 11:02 [PATCH v3 0/4] fs: refactor write_begin/write_end and add ext4 IOCB_DONTCACHE support 陈涛涛 Taotao Chen
2025-06-27 11:03 ` [PATCH v3 1/4] drm/i915: Use kernel_write() in shmem object create 陈涛涛 Taotao Chen
2025-06-27 11:03 ` [PATCH v3 2/4] drm/i915: Refactor shmem_pwrite() to use kiocb and write_iter 陈涛涛 Taotao Chen
2025-06-27 11:03 ` [PATCH v3 3/4] fs: change write_begin/write_end interface to take struct kiocb * 陈涛涛 Taotao Chen
2025-06-27 15:45 ` Matthew Wilcox
2025-07-02 14:12 ` Taotao Chen
2025-06-27 15:52 ` Matthew Wilcox
2025-07-02 14:51 ` Taotao Chen
2025-06-27 11:03 ` [PATCH v3 4/4] ext4: support uncached buffered I/O 陈涛涛 Taotao Chen
2025-06-27 17:03 ` Matthew Wilcox
2025-06-30 6:41 ` hch
2025-07-03 11:45 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aGZtcSIryAj4zJtF@casper.infradead.org \
--to=willy@infradead.org \
--cc=adilger.kernel@dilger.ca \
--cc=airlied@gmail.com \
--cc=brauner@kernel.org \
--cc=chentao325@qq.com \
--cc=chentaotao@didiglobal.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=frank.li@vivo.com \
--cc=hch@infradead.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rodrigo.vivi@intel.com \
--cc=tursulin@ursulin.net \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).