public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
From: Ming Lei <ming.lei@redhat.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Yu Kuai <yukuai1@huaweicloud.com>, Jens Axboe <axboe@kernel.dk>,
	linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
	"yukuai (C)" <yukuai3@huawei.com>
Subject: Re: [PATCH 2/8] block: Do not run frozen queues
Date: Tue, 8 Jul 2025 08:50:35 +0800	[thread overview]
Message-ID: <aGxrW5xK6pFwpTbF@fedora> (raw)
In-Reply-To: <bbf1ec71-6a6c-440d-9ddd-efb5c5e10d44@acm.org>

On Mon, Jul 07, 2025 at 11:22:07AM -0700, Bart Van Assche wrote:
> On 7/2/25 6:51 PM, Ming Lei wrote:
> > The dispatch critical area is much _longer_ than queue_rq()/queue_rqs(),
> > block layer data structure may still be accessed after .q_usage_counter drops
> > to zero.
> 
> I think the above is only correct for block drivers that set the
> BLK_MQ_F_BLOCKING flag. If BLK_MQ_F_BLOCKING is not set,

No, please see my comment:

https://lore.kernel.org/linux-block/aGXiH1HqSlLk-QSI@fedora/

thanks,
Ming


  reply	other threads:[~2025-07-08  0:50 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-02 20:38 [PATCH 0/8] Simplify the code modifying queue attributes Bart Van Assche
2025-07-02 20:38 ` [PATCH 1/8] block: Introduce QUEUE_FLAG_FROZEN Bart Van Assche
2025-07-02 20:38 ` [PATCH 2/8] block: Do not run frozen queues Bart Van Assche
2025-07-03  1:15   ` Yu Kuai
2025-07-03  1:30     ` Bart Van Assche
2025-07-03  1:51       ` Ming Lei
2025-07-03  2:19         ` Yu Kuai
2025-07-07 18:22         ` Bart Van Assche
2025-07-08  0:50           ` Ming Lei [this message]
2025-07-02 20:38 ` [PATCH 3/8] block: Remove the quiesce/unquiesce calls on " Bart Van Assche
2025-07-02 20:38 ` [PATCH 4/8] aoe: " Bart Van Assche
2025-07-02 20:38 ` [PATCH 5/8] ataflop: " Bart Van Assche
2025-07-02 20:38 ` [PATCH 6/8] sunvdc: " Bart Van Assche
2025-07-02 20:38 ` [PATCH 7/8] swim3: " Bart Van Assche
2025-07-04  2:01   ` Damien Le Moal
2025-07-02 20:38 ` [PATCH 8/8] mtd_blkdevs: " Bart Van Assche
2025-07-28 10:14   ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aGxrW5xK6pFwpTbF@fedora \
    --to=ming.lei@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=bvanassche@acm.org \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=yukuai1@huaweicloud.com \
    --cc=yukuai3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox