From: Christoph Hellwig <hch@infradead.org>
To: Klara Modin <klarasmodin@gmail.com>
Cc: brauner@kernel.org, anuj20.g@samsung.com, arnd@kernel.org,
martin.petersen@oracle.com, joshi.k@samsung.com,
hch@infradead.org, arnd@arndb.de, naresh.kamboju@linaro.org,
anders.roxell@linaro.org, axboe@kernel.dk, kbusch@kernel.org,
csander@purestorage.com, asml.silence@gmail.com,
adobriyan@gmail.com, djwong@kernel.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block: change blk_get_meta_cap() stub return -ENOIOCTLCMD
Date: Tue, 29 Jul 2025 00:31:56 -0700 [thread overview]
Message-ID: <aIh47Ncx5lY1vc9F@infradead.org> (raw)
In-Reply-To: <20250725164334.9606-1-klarasmodin@gmail.com>
On Fri, Jul 25, 2025 at 06:43:34PM +0200, Klara Modin wrote:
> When introduced in commit 9eb22f7fedfc ("fs: add ioctl to query metadata
> and protection info capabilities") the stub of blk_get_meta_cap() for
> !BLK_DEV_INTEGRITY always returns -EOPNOTSUPP. The motivation was that
> while the command was unsupported in that configuration it was still
> recognized.
>
> A later change instead assumed -ENOIOCTLCMD as is required for unknown
> ioctl commands per Documentation/driver-api/ioctl.rst. The result being
> that on !BLK_DEV_INTEGRITY configs, any ioctl which reaches
> blkdev_common_ioctl() will return -EOPNOTSUPP.
FYI, I still think we should not fail the command for
!BLK_DEV_INTEGRITY, but just report no capabilities.
next prev parent reply other threads:[~2025-07-29 7:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-25 16:43 [PATCH] block: change blk_get_meta_cap() stub return -ENOIOCTLCMD Klara Modin
2025-07-25 17:45 ` Arnd Bergmann
2025-07-29 7:31 ` Christoph Hellwig [this message]
2025-07-29 11:19 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aIh47Ncx5lY1vc9F@infradead.org \
--to=hch@infradead.org \
--cc=adobriyan@gmail.com \
--cc=anders.roxell@linaro.org \
--cc=anuj20.g@samsung.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=csander@purestorage.com \
--cc=djwong@kernel.org \
--cc=joshi.k@samsung.com \
--cc=kbusch@kernel.org \
--cc=klarasmodin@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=naresh.kamboju@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).