From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E538B1EA91 for ; Sun, 10 Aug 2025 02:20:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754792436; cv=none; b=UenVb4LcG1f1GfiITSLki2juCs+6ZwxGb/GV66ZNmLoxgT/w+BKIcjXK63bxZqcN6bg6Ri7mQVG1m4U9d+vtSw8LsTdnH3X/yZ42Fb9tB8B7TpptllzScYgML/BFyrbME6TJdz3BNW29eCCn5x1dJffjMfCf1AkyUIWUElIL7EM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754792436; c=relaxed/simple; bh=6Pew7s0WnTitAKxA8XpQ2w+u6BlQ+0z6G46rhCW4oYs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=msD/SrxhOv3NaMErpjnV5AVOFBR5qBOMENYoVmI3kP441dC+kPs3J3PTQj6WcDpTkyBtyx0c4VM0M7ii7GLCOu4sqVMHKv7Thm67nO5VuPhcZmK5TTjNclr3decxzoWIwTEsn+vJswM5Lu6m0d1nvj9anFKn1PQeuS6B2v4CCNw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=BExHI8Aj; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="BExHI8Aj" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1754792431; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YnRMiAU3tPcWF7dW1OEzm3VNFxTkrF27m8b5qJprNOA=; b=BExHI8Ajs+DC1KpKR7lLINvm9zlAjTZtQGpu1SdP5EXjbuaPqLZiOwszVYuG+2jEo++Kb7 nW0BDyoZjz34iQijQlpp8HgtB8INb6/tWBYGZ39G95NyAlI0dMEgPmZEiDTsVC4gbdECpc fDf8u9FPG/DvPBd9GRvtJlGwXo9D1fs= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-583-_Wum_dUKN7meicn7rY64dg-1; Sat, 09 Aug 2025 22:20:28 -0400 X-MC-Unique: _Wum_dUKN7meicn7rY64dg-1 X-Mimecast-MFC-AGG-ID: _Wum_dUKN7meicn7rY64dg_1754792427 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 47F9B19560AA; Sun, 10 Aug 2025 02:20:27 +0000 (UTC) Received: from fedora (unknown [10.72.116.24]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5FC751955F16; Sun, 10 Aug 2025 02:20:22 +0000 (UTC) Date: Sun, 10 Aug 2025 10:20:18 +0800 From: Ming Lei To: Caleb Sander Mateos Cc: Jens Axboe , Uday Shankar , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ublk: check for unprivileged daemon on each I/O fetch Message-ID: References: <20250808155216.296170-1-csander@purestorage.com> Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250808155216.296170-1-csander@purestorage.com> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 On Fri, Aug 08, 2025 at 09:52:15AM -0600, Caleb Sander Mateos wrote: > Commit ab03a61c6614 ("ublk: have a per-io daemon instead of a per-queue > daemon") allowed each ublk I/O to have an independent daemon task. > However, nr_privileged_daemon is only computed based on whether the last > I/O fetched in each ublk queue has an unprivileged daemon task. > Fix this by checking whether every fetched I/O's daemon is privileged. > Change nr_privileged_daemon from a count of queues to a boolean > indicating whether any I/Os have an unprivileged daemon. > > Signed-off-by: Caleb Sander Mateos > Fixes: ab03a61c6614 ("ublk: have a per-io daemon instead of a per-queue daemon") Looks fine, Reviewed-by: Ming Lei Thanks, Ming