* Re: [PATCH 2/7] aoe: Stop calling page_address() in free_page()
[not found] ` <20250826193258.902608-3-vishal.moola@gmail.com>
@ 2025-08-26 19:41 ` Matthew Wilcox
2025-08-26 20:12 ` Vishal Moola (Oracle)
0 siblings, 1 reply; 2+ messages in thread
From: Matthew Wilcox @ 2025-08-26 19:41 UTC (permalink / raw)
To: Vishal Moola (Oracle)
Cc: linux-mm, linux-kernel, Andrew Morton, Justin Sanders, Jens Axboe,
linux-block
On Tue, Aug 26, 2025 at 12:32:53PM -0700, Vishal Moola (Oracle) wrote:
> free_page() should be used when we only have a virtual address. We
> should call __free_page() directly on our page instead.
>
> Signed-off-by: Vishal Moola (Oracle) <vishal.moola@gmail.com>
Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Probably should have run ./scripts/get_maintainer.pl drivers/block/aoe/aoecmd.c
Adding ccs.
> drivers/block/aoe/aoecmd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/block/aoe/aoecmd.c b/drivers/block/aoe/aoecmd.c
> index 6298f8e271e3..a9affb7c264d 100644
> --- a/drivers/block/aoe/aoecmd.c
> +++ b/drivers/block/aoe/aoecmd.c
> @@ -1761,6 +1761,6 @@ aoecmd_exit(void)
> kfree(kts);
> kfree(ktiowq);
>
> - free_page((unsigned long) page_address(empty_page));
> + __free_page(empty_page);
> empty_page = NULL;
> }
> --
> 2.51.0
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 2/7] aoe: Stop calling page_address() in free_page()
2025-08-26 19:41 ` [PATCH 2/7] aoe: Stop calling page_address() in free_page() Matthew Wilcox
@ 2025-08-26 20:12 ` Vishal Moola (Oracle)
0 siblings, 0 replies; 2+ messages in thread
From: Vishal Moola (Oracle) @ 2025-08-26 20:12 UTC (permalink / raw)
To: Matthew Wilcox
Cc: linux-mm, linux-kernel, Andrew Morton, Justin Sanders, Jens Axboe,
linux-block
On Tue, Aug 26, 2025 at 08:41:03PM +0100, Matthew Wilcox wrote:
> On Tue, Aug 26, 2025 at 12:32:53PM -0700, Vishal Moola (Oracle) wrote:
> > free_page() should be used when we only have a virtual address. We
> > should call __free_page() directly on our page instead.
> >
> > Signed-off-by: Vishal Moola (Oracle) <vishal.moola@gmail.com>
>
> Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
>
> Probably should have run ./scripts/get_maintainer.pl drivers/block/aoe/aoecmd.c
> Adding ccs.
Ah I thought I did that... seems I messed up some formatting and none of
the ccs got added :/. I'll send out a v2 later today with all the ccs
added.
> > drivers/block/aoe/aoecmd.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/block/aoe/aoecmd.c b/drivers/block/aoe/aoecmd.c
> > index 6298f8e271e3..a9affb7c264d 100644
> > --- a/drivers/block/aoe/aoecmd.c
> > +++ b/drivers/block/aoe/aoecmd.c
> > @@ -1761,6 +1761,6 @@ aoecmd_exit(void)
> > kfree(kts);
> > kfree(ktiowq);
> >
> > - free_page((unsigned long) page_address(empty_page));
> > + __free_page(empty_page);
> > empty_page = NULL;
> > }
> > --
> > 2.51.0
> >
> >
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-08-26 20:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20250826193258.902608-1-vishal.moola@gmail.com>
[not found] ` <20250826193258.902608-3-vishal.moola@gmail.com>
2025-08-26 19:41 ` [PATCH 2/7] aoe: Stop calling page_address() in free_page() Matthew Wilcox
2025-08-26 20:12 ` Vishal Moola (Oracle)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).