From: Christoph Hellwig <hch@infradead.org>
To: Keith Busch <kbusch@meta.com>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org,
ming.lei@redhat.com, Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH] block: rename min_segment_size
Date: Mon, 25 Aug 2025 02:30:25 -0700 [thread overview]
Message-ID: <aKwtMbB0LQGURNMF@infradead.org> (raw)
In-Reply-To: <20250822171038.1847867-1-kbusch@meta.com>
On Fri, Aug 22, 2025 at 10:10:38AM -0700, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
>
> Despite its name, the block layer is fine with segments smaller that the
> "min_segment_size" limit. The value is an optimization limit indicating
> the largest aligned segment that can be used without considering segment
> boundary limits, so give it a name that reflects that.
But max_aligned_segment also feels wrong for that. It's not really
the maximum alignmnet, it is the fast path alignment. Maybe something
like fast_segment_granularity or nosplit_segment_granularity?
next prev parent reply other threads:[~2025-08-25 9:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-22 17:10 [PATCH] block: rename min_segment_size Keith Busch
2025-08-23 3:04 ` Ming Lei
2025-08-25 9:30 ` Christoph Hellwig [this message]
2025-08-25 19:18 ` Martin K. Petersen
2025-08-25 19:50 ` Keith Busch
2025-08-26 7:57 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aKwtMbB0LQGURNMF@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).