Linux block layer
 help / color / mirror / Atom feed
From: Keith Busch <kbusch@kernel.org>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Christoph Hellwig <hch@infradead.org>,
	Keith Busch <kbusch@meta.com>,
	axboe@kernel.dk, linux-block@vger.kernel.org,
	ming.lei@redhat.com
Subject: Re: [PATCH] block: rename min_segment_size
Date: Mon, 25 Aug 2025 13:50:09 -0600	[thread overview]
Message-ID: <aKy-cfmAckSnbrvG@kbusch-mbp> (raw)
In-Reply-To: <yq1h5xvqkij.fsf@ca-mkp.ca.oracle.com>

On Mon, Aug 25, 2025 at 03:18:43PM -0400, Martin K. Petersen wrote:
> 
> Christoph,
> 
> > But max_aligned_segment also feels wrong for that. It's not really the
> > maximum alignmnet, it is the fast path alignment. Maybe something like
> > fast_segment_granularity or nosplit_segment_granularity?
> 
> Maybe just segment_granularity to match the other granularities we have?

I'm not sure I like granularity for this limit. That sounds like it
defines segments to be sized to some multiple of that value, but it's
perfectly fine to use smaller segments.

The limit defines the largest aligned segment the block layer can know
for certain won't need to be split. This allows a short cut while
counting segments without checking against any other limits.

  max_aligned_unsplittable_segment_size

That's pretty verbose, but this limit is kind of unique in its purpose.

  reply	other threads:[~2025-08-25 19:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-22 17:10 [PATCH] block: rename min_segment_size Keith Busch
2025-08-23  3:04 ` Ming Lei
2025-08-25  9:30 ` Christoph Hellwig
2025-08-25 19:18   ` Martin K. Petersen
2025-08-25 19:50     ` Keith Busch [this message]
2025-08-26  7:57       ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aKy-cfmAckSnbrvG@kbusch-mbp \
    --to=kbusch@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=hch@infradead.org \
    --cc=kbusch@meta.com \
    --cc=linux-block@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=ming.lei@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox