Re: [PATCH for-6.18/block 05/16] blk-crypto: fix missing blktrace bio split events

Bart Van Assche
2025-09-05T20:46:16Z

On 9/5/25 12:06 AM, Yu Kuai wrote:
> From: Yu Kuai <yukuai3@huawei.com>
>
> trace_block_split() is missing, resulting in blktrace inability to catch
> BIO split events and making it harder to analyze the BIO sequence.
>
> Cc: stable@vger.kernel.org
> Fixes: 488f6682c832 ("block: blk-crypto-fallback for Inline Encryption")
> Signed-off-by: Yu Kuai <yukuai3@huawei.com>
> ---
> block/blk-crypto-fallback.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/block/blk-crypto-fallback.c b/block/blk-crypto-fallback.c
> index 005c9157ffb3..1f9a4c33d2bd 100644
> --- a/block/blk-crypto-fallback.c
> +++ b/block/blk-crypto-fallback.c
> @@ -18,6 +18,7 @@
> #include <linux/module.h>
> #include <linux/random.h>
> #include <linux/scatterlist.h>
> +#include <trace/events/block.h>
>
> #include "blk-cgroup.h"
> #include "blk-crypto-internal.h"
> @@ -231,7 +232,9 @@ static bool blk_crypto_fallback_split_bio_if_needed(struct bio **bio_ptr)
> bio->bi_status = BLK_STS_RESOURCE;
> return false;
> }
> +
> bio_chain(split_bio, bio);
> + trace_block_split(split_bio, bio->bi_iter.bi_sector);
> submit_bio_noacct(bio);
> *bio_ptr = split_bio;
> }

Ah, here it is. Hence:

Reviewed-by: Bart Van Assche <bvanassche@acm.org>