From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B15F5276030 for ; Sat, 20 Sep 2025 08:52:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758358370; cv=none; b=UEyggAThYi8SECXs28uMRH722JMVWeELAsQsrIUR0cfzfyyIRevl/j/yCS1XtatEKPdNQe05QokA+VRh7H4T4aqsSXYGNq9UE35orn4xiPiehkd9ZsXadm2BiEmAz1D72uwZWmqdTkuRx5MmiA8aFfhphQCkU/hqVFTlPiM0o30= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758358370; c=relaxed/simple; bh=jl4nXCkeF/y/rnhr5/CSMV+KLdXpRTvFcE+ZNU0fuJc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UfBoxYlNgh2TVfc5uiz7t56HDyLUS8ZBARUPRawSQdkAxdTZ3H97DsB3Ak99IDew6EFRkvHsXiYnPr4F2j+j7fXi6iimMJt93tyCzWh6x1mTGKyyzwWUgR+1ZjwYbn2cn/Vy8Fs4pOh8xDX759tc733ZbltVEgkKv2rJTB23RLA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Mte+bjmd; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Mte+bjmd" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1758358367; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=h//h5J7OveIUfIalXM927ElnUVTXbmggL7PCGVQuOtI=; b=Mte+bjmdimPaLXLV54/gItKFRezrQoL8l7cIaW62c0Xs14+5AKrTb3oWCtte5sL01dVr6u FOj5EFalF97A5uRmV3JIQgZYA7EpjhOLWdprS68gafIn2CdFIw0wTE9EUnbjkbfGW3MnSS 4cefOKAcX/GRw9r4IGr3VHDZLnic0zY= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-55-CwGroWpzPG-oObkBfCY9Ww-1; Sat, 20 Sep 2025 04:52:44 -0400 X-MC-Unique: CwGroWpzPG-oObkBfCY9Ww-1 X-Mimecast-MFC-AGG-ID: CwGroWpzPG-oObkBfCY9Ww_1758358363 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B93991800357; Sat, 20 Sep 2025 08:52:42 +0000 (UTC) Received: from fedora (unknown [10.72.120.3]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C3F5130002C5; Sat, 20 Sep 2025 08:52:38 +0000 (UTC) Date: Sat, 20 Sep 2025 16:52:33 +0800 From: Ming Lei To: Caleb Sander Mateos Cc: Jens Axboe , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 03/17] ublk: don't pass ublk_queue to __ublk_fail_req() Message-ID: References: <20250918014953.297897-1-csander@purestorage.com> <20250918014953.297897-4-csander@purestorage.com> Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250918014953.297897-4-csander@purestorage.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 On Wed, Sep 17, 2025 at 07:49:39PM -0600, Caleb Sander Mateos wrote: > __ublk_fail_req() only uses the ublk_queue to get the ublk_device, which > its caller already has. So just pass the ublk_device directly. > > Signed-off-by: Caleb Sander Mateos Reviewed-by: Ming Lei Thanks, Ming