From: Ming Lei <ming.lei@redhat.com>
To: Uday Shankar <ushankar@purestorage.com>
Cc: Caleb Sander Mateos <csander@purestorage.com>,
Shuah Khan <shuah@kernel.org>,
linux-block@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] selftests: ublk: kublk: add UBLK_F_BUF_REG_OFF_DAEMON to feat_map
Date: Wed, 17 Sep 2025 11:50:33 +0800 [thread overview]
Message-ID: <aMowCXGbmJ4Ob1h7@fedora> (raw)
In-Reply-To: <20250916-ublk_features-v1-2-52014be9cde5@purestorage.com>
On Tue, Sep 16, 2025 at 04:05:56PM -0600, Uday Shankar wrote:
> When UBLK_F_BUF_REG_OFF_DAEMON was added, we missed updating kublk's
> feat_map, which results in the feature being reported as "unknown." Add
> UBLK_F_BUF_REG_OFF_DAEMON to feat_map to fix this.
>
> Signed-off-by: Uday Shankar <ushankar@purestorage.com>
> ---
> tools/testing/selftests/ublk/kublk.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/selftests/ublk/kublk.c b/tools/testing/selftests/ublk/kublk.c
> index 4e5d82f2a14a01d9e56d31126eae2e26ec718b6c..b636d40b4889d88f7d64d0e71c6f09eca17e3989 100644
> --- a/tools/testing/selftests/ublk/kublk.c
> +++ b/tools/testing/selftests/ublk/kublk.c
> @@ -1379,6 +1379,7 @@ static int cmd_dev_get_features(void)
> FEAT_NAME(UBLK_F_AUTO_BUF_REG),
> FEAT_NAME(UBLK_F_QUIESCE),
> FEAT_NAME(UBLK_F_PER_IO_DAEMON),
> + FEAT_NAME(UBLK_F_BUF_REG_OFF_DAEMON),
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Thanks,
Ming
next prev parent reply other threads:[~2025-09-17 3:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-16 22:05 [PATCH 0/3] selftests: ublk: kublk: fix feature list Uday Shankar
2025-09-16 22:05 ` [PATCH 1/3] selftests: ublk: kublk: simplify feat_map definition Uday Shankar
2025-09-17 3:49 ` Ming Lei
2025-09-16 22:05 ` [PATCH 2/3] selftests: ublk: kublk: add UBLK_F_BUF_REG_OFF_DAEMON to feat_map Uday Shankar
2025-09-17 3:50 ` Ming Lei [this message]
2025-09-16 22:05 ` [PATCH 3/3] selftests: ublk: add test to verify that feat_map is complete Uday Shankar
2025-09-17 3:52 ` Ming Lei
2025-09-17 19:12 ` Uday Shankar
2025-09-18 0:23 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aMowCXGbmJ4Ob1h7@fedora \
--to=ming.lei@redhat.com \
--cc=csander@purestorage.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=ushankar@purestorage.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox