From: Christoph Hellwig <hch@infradead.org>
To: chengkaitao <pilgrimtao@gmail.com>
Cc: axboe@kernel.dk, dlemoal@kernel.org, yukuai3@huawei.com,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
Chengkaitao <chengkaitao@kylinos.cn>
Subject: Re: [PATCH] block: Remove redundant hctx pointer dereferencing operation
Date: Thu, 16 Oct 2025 23:27:33 -0700 [thread overview]
Message-ID: <aPHh1eTQRDO3z6Yb@infradead.org> (raw)
In-Reply-To: <20251016131651.83182-1-pilgrimtao@gmail.com>
On Thu, Oct 16, 2025 at 09:16:51PM +0800, chengkaitao wrote:
> From: Chengkaitao <chengkaitao@kylinos.cn>
>
> The {*q = hctx->queue} statement in the dd_insert_requestfunction is
> redundant. This patch removes the operation and modifies the function's
> formal parameters accordingly.
What formal parameters?
Basically you're passing a pointless extra argument instead of deriving
it locally. Why would you do that?
next prev parent reply other threads:[~2025-10-17 6:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-16 13:16 [PATCH] block: Remove redundant hctx pointer dereferencing operation chengkaitao
2025-10-17 6:27 ` Christoph Hellwig [this message]
2025-10-17 6:54 ` Tao pilgrim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPHh1eTQRDO3z6Yb@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=chengkaitao@kylinos.cn \
--cc=dlemoal@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pilgrimtao@gmail.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox