From: Christoph Hellwig <hch@infradead.org>
To: Kent Overstreet <kent.overstreet@linux.dev>
Cc: Christoph Hellwig <hch@infradead.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-block@vger.kernel.org
Subject: Re: [GIT PULL] block-bio_iov_iter_export
Date: Mon, 20 Oct 2025 02:35:40 -0700 [thread overview]
Message-ID: <aPYCbIrvAkOf5L3g@infradead.org> (raw)
In-Reply-To: <6strysb6whhovk4rlaujravntyt2umocsjfsaxtl4jnuvjjbsp@sqf6ncn3yrlm>
On Fri, Oct 17, 2025 at 09:31:59AM -0400, Kent Overstreet wrote:
> On Thu, Oct 16, 2025 at 11:13:46PM -0700, Christoph Hellwig wrote:
> > Umm,
> >
> > besides adding exports without in-tree users, this is a patch that's
> > never seen any relevant mailing list, in a pull request that the
> > maintainer hasn't seen. That's now exactly how Linux development works,
> > does it?
>
> Christoph, I wrote that code /for bcachefs/; the rest of you decided it
> was nice and started using it too.
In fact this version was written by me, giving you the attribution
because I stole a cool idea from you. But none of this actually
matters, there's not magic exception just because someone wrote the
code.
> Then you removed the export talking about the "abuse" of bcachefs using
> it. WTF?
The random NULL bdev check that breaks the proper splitting. We told
told you that's not the way to go, but you just sent it directly to Linus
instead of reworking it. And this then got into the way of the rework
Keith did to support arbitrarily small memory alignments. Fortunately
we could clean this up properly now.
next prev parent reply other threads:[~2025-10-20 9:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <ov54jszhism7mbeu74vtyoysxnx3y3tsjbj5esszlrx3edq77s@j2vtyy45gsna>
2025-10-17 6:13 ` [GIT PULL] block-bio_iov_iter_export Christoph Hellwig
2025-10-17 13:31 ` Kent Overstreet
2025-10-20 9:35 ` Christoph Hellwig [this message]
2025-10-20 12:56 ` Kent Overstreet
2025-10-20 13:21 ` Christoph Hellwig
2025-10-20 14:49 ` Kent Overstreet
2025-10-20 14:54 ` Christoph Hellwig
2025-10-20 16:42 ` Kent Overstreet
2025-10-20 15:13 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPYCbIrvAkOf5L3g@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=gregkh@linuxfoundation.org \
--cc=kent.overstreet@linux.dev \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).