Linux block layer
 help / color / mirror / Atom feed
From: Keith Busch <kbusch@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Keith Busch <kbusch@meta.com>,
	linux-block@vger.kernel.org, axboe@kernel.dk,
	martin.petersen@oracle.com
Subject: Re: [PATCHv2] blk-integrity: support arbitrary buffer alignment
Date: Fri, 7 Nov 2025 08:00:26 -0700	[thread overview]
Message-ID: <aQ4JihZLWPrrgdCK@kbusch-mbp> (raw)
In-Reply-To: <20251107131519.GA3975@lst.de>

On Fri, Nov 07, 2025 at 02:15:19PM +0100, Christoph Hellwig wrote:
> On Thu, Nov 06, 2025 at 08:34:47PM -0800, Keith Busch wrote:
> > This was tested using recently proposed io_uring metadata test case
> > here:
> > 
> >   https://lore.kernel.org/io-uring/20251107042953.3393507-1-kbusch@meta.com/
> 
> Any chance we could get this test or something like it into blktests?
> 
> That way it would get regularly run as part of block layer validation.

I'll give it a shot. The only problem is that liburing currently doesn't
define the SQE fields or pi attributes for this feature, so we'd need to
have blktests conditionally redefine things depending on which liburing
version the system is using.
 
> The changes looks sensible to be, and pass very basic sanity testing
> using my PI setup.  I have few cleanups we should get into (attached).

Thanks! These all look good to me. If it's okay with you, I'll fold
these in and tag you for Co-developed-by.

  reply	other threads:[~2025-11-07 15:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-07  4:34 [PATCHv2] blk-integrity: support arbitrary buffer alignment Keith Busch
2025-11-07 13:15 ` Christoph Hellwig
2025-11-07 15:00   ` Keith Busch [this message]
2025-11-07 15:35     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aQ4JihZLWPrrgdCK@kbusch-mbp \
    --to=kbusch@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=kbusch@meta.com \
    --cc=linux-block@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox