From: Keith Busch <kbusch@kernel.org>
To: Hans Holmberg <Hans.Holmberg@wdc.com>
Cc: Jens Axboe <axboe@kernel.dk>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
Damien Le Moal <dlemoal@kernel.org>,
Johannes Thumshirn <Johannes.Thumshirn@wdc.com>, hch <hch@lst.de>,
Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>,
Andreas Hindborg <a.hindborg@kernel.org>
Subject: Re: [PATCH] null_blk: set dma alignment to logical block size
Date: Wed, 29 Oct 2025 10:15:54 -0600 [thread overview]
Message-ID: <aQI9uiTuEr8hbWbC@kbusch-mbp> (raw)
In-Reply-To: <aQI7hyET6f-nXnmp@kbusch-mbp>
On Wed, Oct 29, 2025 at 10:06:31AM -0600, Keith Busch wrote:
>
> After this, you can set dma_alignment to 1.
Oh wait, no, it still can't be smaller than 511 because everything
operates on "SECTOR_SIZE". Which also seems like it shouldn't be
necessary...
Sorry, let's just do your patch. That seems the safest thing for now,
and I can mess with dma alignment limits for a follow up (I'm already
doing something similiar for generic protection information).
Reviewed-by: Keith Busch <kbusch@kernel.org>
next prev parent reply other threads:[~2025-10-29 16:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-29 13:39 [PATCH] null_blk: set dma alignment to logical block size Hans Holmberg
2025-10-29 13:51 ` Christoph Hellwig
2025-10-29 13:51 ` Christoph Hellwig
2025-10-29 14:12 ` Keith Busch
2025-10-29 15:32 ` Hans Holmberg
2025-10-29 16:01 ` Hans Holmberg
2025-10-29 16:06 ` Keith Busch
2025-10-29 16:15 ` Keith Busch [this message]
2025-10-30 12:32 ` Hans Holmberg
2025-10-31 9:00 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQI9uiTuEr8hbWbC@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=Hans.Holmberg@wdc.com \
--cc=Johannes.Thumshirn@wdc.com \
--cc=a.hindborg@kernel.org \
--cc=axboe@kernel.dk \
--cc=dlemoal@kernel.org \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox