* [PATCH] block: fix typos in comments and strings in blk-core.c
@ 2025-11-04 6:21 shechenglong
2025-11-04 6:28 ` Chaitanya Kulkarni
2025-11-04 11:07 ` Christoph Hellwig
0 siblings, 2 replies; 9+ messages in thread
From: shechenglong @ 2025-11-04 6:21 UTC (permalink / raw)
To: axboe; +Cc: linux-block, linux-kernel, stone.xulei, chenjialong, shechenglong
This patch fixes multiple spelling mistakes in comments and documentation
in the file block/blk-core.c.
No functional changes intended.
Signed-off-by: shechenglong <shechenglong@xfusion.com>
---
block/blk-core.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/block/blk-core.c b/block/blk-core.c
index 14ae73eebe0d..7757cd589b59 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -662,13 +662,13 @@ static void __submit_bio(struct bio *bio)
* bio_list of new bios to be added. ->submit_bio() may indeed add some more
* bios through a recursive call to submit_bio_noacct. If it did, we find a
* non-NULL value in bio_list and re-enter the loop from the top.
- * - In this case we really did just take the bio of the top of the list (no
+ * - In this case we really did just take the bio off the top of the list (no
* pretending) and so remove it from bio_list, and call into ->submit_bio()
* again.
*
* bio_list_on_stack[0] contains bios submitted by the current ->submit_bio.
* bio_list_on_stack[1] contains bios that were submitted before the current
- * ->submit_bio, but that haven't been processed yet.
+ * ->submit_bio(), but that haven't been processed yet.
*/
static void __submit_bio_noacct(struct bio *bio)
{
@@ -743,7 +743,7 @@ void submit_bio_noacct_nocheck(struct bio *bio, bool split)
/*
* We only want one ->submit_bio to be active at a time, else stack
* usage with stacked devices could be a problem. Use current->bio_list
- * to collect a list of requests submited by a ->submit_bio method while
+ * to collect a list of requests submitted by a ->submit_bio method while
* it is active, and then process them after it returned.
*/
if (current->bio_list) {
@@ -901,7 +901,7 @@ static void bio_set_ioprio(struct bio *bio)
*
* submit_bio() is used to submit I/O requests to block devices. It is passed a
* fully set up &struct bio that describes the I/O that needs to be done. The
- * bio will be send to the device described by the bi_bdev field.
+ * bio will be sent to the device described by the bi_bdev field.
*
* The success/failure status of the request, along with notification of
* completion, is delivered asynchronously through the ->bi_end_io() callback
@@ -991,7 +991,7 @@ int iocb_bio_iopoll(struct kiocb *kiocb, struct io_comp_batch *iob,
* point to a freshly allocated bio at this point. If that happens
* we have a few cases to consider:
*
- * 1) the bio is beeing initialized and bi_bdev is NULL. We can just
+ * 1) the bio is being initialized and bi_bdev is NULL. We can just
* simply nothing in this case
* 2) the bio points to a not poll enabled device. bio_poll will catch
* this and return 0
--
2.33.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] block: fix typos in comments and strings in blk-core.c
2025-11-04 6:21 [PATCH] block: fix typos in comments and strings in blk-core.c shechenglong
@ 2025-11-04 6:28 ` Chaitanya Kulkarni
2025-11-04 11:07 ` Christoph Hellwig
1 sibling, 0 replies; 9+ messages in thread
From: Chaitanya Kulkarni @ 2025-11-04 6:28 UTC (permalink / raw)
To: shechenglong, axboe@kernel.dk
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
stone.xulei@xfusion.com, chenjialong@xfusion.com
On 11/3/25 22:21, shechenglong wrote:
> This patch fixes multiple spelling mistakes in comments and documentation
> in the file block/blk-core.c.
>
> No functional changes intended.
>
> Signed-off-by: shechenglong<shechenglong@xfusion.com>
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] block: fix typos in comments and strings in blk-core.c
2025-11-04 6:21 [PATCH] block: fix typos in comments and strings in blk-core.c shechenglong
2025-11-04 6:28 ` Chaitanya Kulkarni
@ 2025-11-04 11:07 ` Christoph Hellwig
2025-11-04 12:34 ` [PATCH v2 0/1] block: fix typos in comments and strings in blk-core shechenglong
1 sibling, 1 reply; 9+ messages in thread
From: Christoph Hellwig @ 2025-11-04 11:07 UTC (permalink / raw)
To: shechenglong; +Cc: axboe, linux-block, linux-kernel, stone.xulei, chenjialong
On Tue, Nov 04, 2025 at 02:21:13PM +0800, shechenglong wrote:
> * usage with stacked devices could be a problem. Use current->bio_list
> - * to collect a list of requests submited by a ->submit_bio method while
> + * to collect a list of requests submitted by a ->submit_bio method while
This now adds an overly long line.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 0/1] block: fix typos in comments and strings in blk-core
2025-11-04 11:07 ` Christoph Hellwig
@ 2025-11-04 12:34 ` shechenglong
2025-11-04 12:35 ` [PATCH v2 1/1] " shechenglong
2025-11-25 17:41 ` (subset) [PATCH v2 0/1] " Jens Axboe
0 siblings, 2 replies; 9+ messages in thread
From: shechenglong @ 2025-11-04 12:34 UTC (permalink / raw)
To: hch, axboe
Cc: linux-block, linux-kernel, stone.xulei, chenjialong, shechenglong
> This now adds an overly long line.
Hi Christoph,
Thank you for your review and feedback.I've fixed the overly long line
by splitting it as you suggested.
shechenglong (1):
block: fix typos in comments and strings in blk-core
block/blk-core.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
--
2.33.0
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 1/1] block: fix typos in comments and strings in blk-core
2025-11-04 12:34 ` [PATCH v2 0/1] block: fix typos in comments and strings in blk-core shechenglong
@ 2025-11-04 12:35 ` shechenglong
2025-11-24 2:02 ` [RESEND PATCH v2 0/1] " shechenglong
2025-11-25 17:41 ` (subset) [PATCH v2 0/1] " Jens Axboe
1 sibling, 1 reply; 9+ messages in thread
From: shechenglong @ 2025-11-04 12:35 UTC (permalink / raw)
To: hch, axboe
Cc: linux-block, linux-kernel, stone.xulei, chenjialong, shechenglong,
Chaitanya Kulkarni
This patch fixes multiple spelling mistakes in comments and documentation
in the file block/blk-core.c.
No functional changes intended.
Suggested-by: Christoph Hellwig <hch@infradead.org>
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
Signed-off-by: shechenglong <shechenglong@xfusion.com>
---
block/blk-core.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/block/blk-core.c b/block/blk-core.c
index 14ae73eebe0d..8387fe50ea15 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -662,13 +662,13 @@ static void __submit_bio(struct bio *bio)
* bio_list of new bios to be added. ->submit_bio() may indeed add some more
* bios through a recursive call to submit_bio_noacct. If it did, we find a
* non-NULL value in bio_list and re-enter the loop from the top.
- * - In this case we really did just take the bio of the top of the list (no
+ * - In this case we really did just take the bio off the top of the list (no
* pretending) and so remove it from bio_list, and call into ->submit_bio()
* again.
*
* bio_list_on_stack[0] contains bios submitted by the current ->submit_bio.
* bio_list_on_stack[1] contains bios that were submitted before the current
- * ->submit_bio, but that haven't been processed yet.
+ * ->submit_bio(), but that haven't been processed yet.
*/
static void __submit_bio_noacct(struct bio *bio)
{
@@ -743,8 +743,8 @@ void submit_bio_noacct_nocheck(struct bio *bio, bool split)
/*
* We only want one ->submit_bio to be active at a time, else stack
* usage with stacked devices could be a problem. Use current->bio_list
- * to collect a list of requests submited by a ->submit_bio method while
- * it is active, and then process them after it returned.
+ * to collect a list of requests submitted by a ->submit_bio method
+ * while it is active, and then process them after it returned.
*/
if (current->bio_list) {
if (split)
@@ -901,7 +901,7 @@ static void bio_set_ioprio(struct bio *bio)
*
* submit_bio() is used to submit I/O requests to block devices. It is passed a
* fully set up &struct bio that describes the I/O that needs to be done. The
- * bio will be send to the device described by the bi_bdev field.
+ * bio will be sent to the device described by the bi_bdev field.
*
* The success/failure status of the request, along with notification of
* completion, is delivered asynchronously through the ->bi_end_io() callback
@@ -991,7 +991,7 @@ int iocb_bio_iopoll(struct kiocb *kiocb, struct io_comp_batch *iob,
* point to a freshly allocated bio at this point. If that happens
* we have a few cases to consider:
*
- * 1) the bio is beeing initialized and bi_bdev is NULL. We can just
+ * 1) the bio is being initialized and bi_bdev is NULL. We can just
* simply nothing in this case
* 2) the bio points to a not poll enabled device. bio_poll will catch
* this and return 0
--
2.33.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [RESEND PATCH v2 0/1] block: fix typos in comments and strings in blk-core
2025-11-04 12:35 ` [PATCH v2 1/1] " shechenglong
@ 2025-11-24 2:02 ` shechenglong
2025-11-24 2:02 ` [PATCH v2 1/1] " shechenglong
0 siblings, 1 reply; 9+ messages in thread
From: shechenglong @ 2025-11-24 2:02 UTC (permalink / raw)
To: axboe, hch
Cc: linux-block, linux-kernel, kch, stone.xulei, chenjialong,
shechenglong
> This now adds an overly long line.
Hi Christoph,
Thank you for your review and feedback.I've fixed the overly long line
by splitting it as you suggested.
shechenglong (1):
block: fix typos in comments and strings in blk-core
block/blk-core.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
--
2.33.0
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 1/1] block: fix typos in comments and strings in blk-core
2025-11-24 2:02 ` [RESEND PATCH v2 0/1] " shechenglong
@ 2025-11-24 2:02 ` shechenglong
2025-11-24 14:05 ` Christoph Hellwig
0 siblings, 1 reply; 9+ messages in thread
From: shechenglong @ 2025-11-24 2:02 UTC (permalink / raw)
To: axboe, hch
Cc: linux-block, linux-kernel, kch, stone.xulei, chenjialong,
shechenglong
This patch fixes multiple spelling mistakes in comments and documentation
in the file block/blk-core.c.
No functional changes intended.
Suggested-by: Christoph Hellwig <hch@infradead.org>
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
Signed-off-by: shechenglong <shechenglong@xfusion.com>
---
block/blk-core.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/block/blk-core.c b/block/blk-core.c
index 14ae73eebe0d..8387fe50ea15 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -662,13 +662,13 @@ static void __submit_bio(struct bio *bio)
* bio_list of new bios to be added. ->submit_bio() may indeed add some more
* bios through a recursive call to submit_bio_noacct. If it did, we find a
* non-NULL value in bio_list and re-enter the loop from the top.
- * - In this case we really did just take the bio of the top of the list (no
+ * - In this case we really did just take the bio off the top of the list (no
* pretending) and so remove it from bio_list, and call into ->submit_bio()
* again.
*
* bio_list_on_stack[0] contains bios submitted by the current ->submit_bio.
* bio_list_on_stack[1] contains bios that were submitted before the current
- * ->submit_bio, but that haven't been processed yet.
+ * ->submit_bio(), but that haven't been processed yet.
*/
static void __submit_bio_noacct(struct bio *bio)
{
@@ -743,8 +743,8 @@ void submit_bio_noacct_nocheck(struct bio *bio, bool split)
/*
* We only want one ->submit_bio to be active at a time, else stack
* usage with stacked devices could be a problem. Use current->bio_list
- * to collect a list of requests submited by a ->submit_bio method while
- * it is active, and then process them after it returned.
+ * to collect a list of requests submitted by a ->submit_bio method
+ * while it is active, and then process them after it returned.
*/
if (current->bio_list) {
if (split)
@@ -901,7 +901,7 @@ static void bio_set_ioprio(struct bio *bio)
*
* submit_bio() is used to submit I/O requests to block devices. It is passed a
* fully set up &struct bio that describes the I/O that needs to be done. The
- * bio will be send to the device described by the bi_bdev field.
+ * bio will be sent to the device described by the bi_bdev field.
*
* The success/failure status of the request, along with notification of
* completion, is delivered asynchronously through the ->bi_end_io() callback
@@ -991,7 +991,7 @@ int iocb_bio_iopoll(struct kiocb *kiocb, struct io_comp_batch *iob,
* point to a freshly allocated bio at this point. If that happens
* we have a few cases to consider:
*
- * 1) the bio is beeing initialized and bi_bdev is NULL. We can just
+ * 1) the bio is being initialized and bi_bdev is NULL. We can just
* simply nothing in this case
* 2) the bio points to a not poll enabled device. bio_poll will catch
* this and return 0
--
2.33.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v2 1/1] block: fix typos in comments and strings in blk-core
2025-11-24 2:02 ` [PATCH v2 1/1] " shechenglong
@ 2025-11-24 14:05 ` Christoph Hellwig
0 siblings, 0 replies; 9+ messages in thread
From: Christoph Hellwig @ 2025-11-24 14:05 UTC (permalink / raw)
To: shechenglong
Cc: axboe, hch, linux-block, linux-kernel, kch, stone.xulei,
chenjialong
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: (subset) [PATCH v2 0/1] block: fix typos in comments and strings in blk-core
2025-11-04 12:34 ` [PATCH v2 0/1] block: fix typos in comments and strings in blk-core shechenglong
2025-11-04 12:35 ` [PATCH v2 1/1] " shechenglong
@ 2025-11-25 17:41 ` Jens Axboe
1 sibling, 0 replies; 9+ messages in thread
From: Jens Axboe @ 2025-11-25 17:41 UTC (permalink / raw)
To: hch, shechenglong; +Cc: linux-block, linux-kernel, stone.xulei, chenjialong
On Tue, 04 Nov 2025 20:34:59 +0800, shechenglong wrote:
> > This now adds an overly long line.
>
> Hi Christoph,
>
> Thank you for your review and feedback.I've fixed the overly long line
> by splitting it as you suggested.
>
> [...]
Applied, thanks!
[1/1] block: fix typos in comments and strings in blk-core
commit: 3a64c46c40460386aeca6e8698076d1207aeaf44
Best regards,
--
Jens Axboe
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2025-11-25 17:41 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-04 6:21 [PATCH] block: fix typos in comments and strings in blk-core.c shechenglong
2025-11-04 6:28 ` Chaitanya Kulkarni
2025-11-04 11:07 ` Christoph Hellwig
2025-11-04 12:34 ` [PATCH v2 0/1] block: fix typos in comments and strings in blk-core shechenglong
2025-11-04 12:35 ` [PATCH v2 1/1] " shechenglong
2025-11-24 2:02 ` [RESEND PATCH v2 0/1] " shechenglong
2025-11-24 2:02 ` [PATCH v2 1/1] " shechenglong
2025-11-24 14:05 ` Christoph Hellwig
2025-11-25 17:41 ` (subset) [PATCH v2 0/1] " Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).