From: Keith Busch <kbusch@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Keith Busch <kbusch@meta.com>,
linux-block@vger.kernel.org, martin.petersen@oracle.com,
axboe@kernel.dk
Subject: Re: [RFC PATCH] blk-integrity: support arbitrary buffer alignment
Date: Wed, 5 Nov 2025 07:51:32 -0700 [thread overview]
Message-ID: <aQtkdNQOA1Twvoeh@kbusch-mbp> (raw)
In-Reply-To: <aQtiYd69E-3G_PC4@kbusch-mbp>
On Wed, Nov 05, 2025 at 07:42:41AM -0700, Keith Busch wrote:
> On Wed, Nov 05, 2025 at 03:15:04PM +0100, Christoph Hellwig wrote:
...
> > What does that union of two pointers
...
> Using a union ensures that it's definitely big enough for any
> checksum type.
Oh geez, it should have been a union of the structs, not pointers to
those types... So this is a mistake in the code, but I hope the
intention is more clear.
next prev parent reply other threads:[~2025-11-05 14:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-04 22:40 [RFC PATCH] blk-integrity: support arbitrary buffer alignment Keith Busch
2025-11-05 14:15 ` Christoph Hellwig
2025-11-05 14:42 ` Keith Busch
2025-11-05 14:51 ` Keith Busch [this message]
2025-11-05 14:53 ` Christoph Hellwig
2025-11-05 16:28 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQtkdNQOA1Twvoeh@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kbusch@meta.com \
--cc=linux-block@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox