From: Keith Busch <kbusch@kernel.org>
To: Chaitanya Kulkarni <chaitanyak@nvidia.com>
Cc: Keith Busch <kbusch@meta.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"shinichiro.kawasaki@wdc.com" <shinichiro.kawasaki@wdc.com>
Subject: Re: [PATCHv2 1/2] blktests: test direct io offsets
Date: Wed, 19 Nov 2025 16:59:06 -0700 [thread overview]
Message-ID: <aR5ZyoBaX-47tgNn@kbusch-mbp> (raw)
In-Reply-To: <ddda3d01-b95e-4798-b21d-a0c526b5b5a8@nvidia.com>
On Wed, Nov 19, 2025 at 11:48:47PM +0000, Chaitanya Kulkarni wrote:
> On 11/19/25 11:54, Keith Busch wrote:
> > + ret = pwritev(test_fd, iov, vecs, 0);
> > + if (ret < 0)
> > + err(errno, "%s: failed to read buf", __func__);
> > +
>
>
> is pwritev correct above or it should be preadv () ?
Good eye, it should have been preadv. This part is currently unreachable
though, as it requires byte-aligned dma limits and the kernel doesn't
report such a value. But if this were to run, the test would have
falsely declared data corruption.
next prev parent reply other threads:[~2025-11-19 23:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-19 19:54 [PATCHv2 0/2] blktests: add tests with offsets Keith Busch
2025-11-19 19:54 ` [PATCHv2 1/2] blktests: test direct io offsets Keith Busch
2025-11-19 23:39 ` Chaitanya Kulkarni
2025-11-19 23:48 ` Chaitanya Kulkarni
2025-11-19 23:59 ` Keith Busch [this message]
2025-11-20 0:56 ` Chaitanya Kulkarni
2025-11-20 14:32 ` Keith Busch
2025-11-25 11:26 ` Shinichiro Kawasaki
2025-11-25 16:42 ` Keith Busch
2025-12-02 10:22 ` Shinichiro Kawasaki
2025-11-19 19:54 ` [PATCHv2 2/2] blktests: test io_uring user metadata offsets Keith Busch
2025-11-19 23:39 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aR5ZyoBaX-47tgNn@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=chaitanyak@nvidia.com \
--cc=kbusch@meta.com \
--cc=linux-block@vger.kernel.org \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox