public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] blk-mq-dma: fix kernel-doc function name for integrity DMA  iterator
@ 2025-11-11 11:58 Kriish Sharma
  2025-11-11 14:10 ` Christoph Hellwig
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Kriish Sharma @ 2025-11-11 11:58 UTC (permalink / raw)
  To: axboe; +Cc: linux-block, linux-kernel, Kriish Sharma

Documentation build reported:

  Warning: block/blk-mq-dma.c:373 expecting prototype for blk_rq_integrity_dma_map_iter_start(). Prototype was for blk_rq_integrity_dma_map_iter_next() instead

The kernel-doc comment above `blk_rq_integrity_dma_map_iter_next()` used
the wrong function name (`blk_rq_integrity_dma_map_iter_start`) in its
header. This patch corrects the function name in the kernel-doc block to
match the actual implementation, ensuring clean documentation builds.

Fixes: fec9b16dc555 ("blk-mq-dma: add scatter-less integrity data DMA mapping")
Signed-off-by: Kriish Sharma <kriish.sharma2006@gmail.com>
---
 block/blk-mq-dma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block/blk-mq-dma.c b/block/blk-mq-dma.c
index a7ef25843280..b4f456472961 100644
--- a/block/blk-mq-dma.c
+++ b/block/blk-mq-dma.c
@@ -351,7 +351,7 @@ bool blk_rq_integrity_dma_map_iter_start(struct request *req,
 EXPORT_SYMBOL_GPL(blk_rq_integrity_dma_map_iter_start);
 
 /**
- * blk_rq_integrity_dma_map_iter_start - map the next integrity DMA segment for
+ * blk_rq_integrity_dma_map_iter_next - map the next integrity DMA segment for
  * 					 a request
  * @req:	request to map
  * @dma_dev:	device to map to
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] blk-mq-dma: fix kernel-doc function name for integrity DMA  iterator
  2025-11-11 11:58 [PATCH] blk-mq-dma: fix kernel-doc function name for integrity DMA iterator Kriish Sharma
@ 2025-11-11 14:10 ` Christoph Hellwig
  2025-11-11 15:39 ` Jens Axboe
  2025-11-11 16:01 ` Chaitanya Kulkarni
  2 siblings, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2025-11-11 14:10 UTC (permalink / raw)
  To: Kriish Sharma; +Cc: axboe, linux-block, linux-kernel

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] blk-mq-dma: fix kernel-doc function name for integrity DMA iterator
  2025-11-11 11:58 [PATCH] blk-mq-dma: fix kernel-doc function name for integrity DMA iterator Kriish Sharma
  2025-11-11 14:10 ` Christoph Hellwig
@ 2025-11-11 15:39 ` Jens Axboe
  2025-11-11 16:01 ` Chaitanya Kulkarni
  2 siblings, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2025-11-11 15:39 UTC (permalink / raw)
  To: Kriish Sharma; +Cc: linux-block, linux-kernel


On Tue, 11 Nov 2025 11:58:10 +0000, Kriish Sharma wrote:
> Documentation build reported:
> 
>   Warning: block/blk-mq-dma.c:373 expecting prototype for blk_rq_integrity_dma_map_iter_start(). Prototype was for blk_rq_integrity_dma_map_iter_next() instead
> 
> The kernel-doc comment above `blk_rq_integrity_dma_map_iter_next()` used
> the wrong function name (`blk_rq_integrity_dma_map_iter_start`) in its
> header. This patch corrects the function name in the kernel-doc block to
> match the actual implementation, ensuring clean documentation builds.
> 
> [...]

Applied, thanks!

[1/1] blk-mq-dma: fix kernel-doc function name for integrity DMA iterator
      commit: 6d7e3870af11c2b5966b2769f9e8a0d4764f52cc

Best regards,
-- 
Jens Axboe




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] blk-mq-dma: fix kernel-doc function name for integrity DMA iterator
  2025-11-11 11:58 [PATCH] blk-mq-dma: fix kernel-doc function name for integrity DMA iterator Kriish Sharma
  2025-11-11 14:10 ` Christoph Hellwig
  2025-11-11 15:39 ` Jens Axboe
@ 2025-11-11 16:01 ` Chaitanya Kulkarni
  2 siblings, 0 replies; 4+ messages in thread
From: Chaitanya Kulkarni @ 2025-11-11 16:01 UTC (permalink / raw)
  To: Kriish Sharma, axboe@kernel.dk
  Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org

On 11/11/25 03:58, Kriish Sharma wrote:
> Documentation build reported:
>
>    Warning: block/blk-mq-dma.c:373 expecting prototype for blk_rq_integrity_dma_map_iter_start(). Prototype was for blk_rq_integrity_dma_map_iter_next() instead
>
> The kernel-doc comment above `blk_rq_integrity_dma_map_iter_next()` used
> the wrong function name (`blk_rq_integrity_dma_map_iter_start`) in its
> header. This patch corrects the function name in the kernel-doc block to
> match the actual implementation, ensuring clean documentation builds.
>
> Fixes: fec9b16dc555 ("blk-mq-dma: add scatter-less integrity data DMA mapping")
> Signed-off-by: Kriish Sharma<kriish.sharma2006@gmail.com>


Looks good.

Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>

-ck



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-11-11 16:01 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-11 11:58 [PATCH] blk-mq-dma: fix kernel-doc function name for integrity DMA iterator Kriish Sharma
2025-11-11 14:10 ` Christoph Hellwig
2025-11-11 15:39 ` Jens Axboe
2025-11-11 16:01 ` Chaitanya Kulkarni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox